fix(ci): revert changesets/action to v1.9.0 and ignore its majors - #385
Merged
Conversation
The v2.0.0 bump in #384 broke the release workflow on main. v2 renames every input, so the existing `with:` block became invalid: version -> version-script, publish -> publish-script, commit -> commit-message, title -> pr-title, createGithubReleases -> create-github-releases More fundamentally, v2 cannot work here yet: - It validates that the project uses Changesets CLI v3 and directs CLI v2 users back to @v1. apps/ui is on @changesets/cli 2.31.0. - It removes `cwd`, which this monorepo depends on — .changeset lives in apps/ui, not the repo root. - Custom version/publish scripts must now thread CHANGESETS_OUTPUT through to the CLI for published-package detection. Reverts to the exact SHA main ran before #384 and ignores the major so Dependabot stops re-proposing it, matching the @astrojs/cloudflare and elysia-rate-limit entries. Taking v2 is a deliberate piece of work alongside the CLI v3 upgrade. Worth noting for future action bumps: Dependabot bumped a major action version without touching its inputs, and no PR-triggered workflow exercises apps-ui-release.yml, so this could only surface on merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
releaseworkflow failing onmain(run 31777307881) by revertingchangesets/actionto the exact SHA main ran before chore(deps): batch the post-#361 Dependabot wave #384.What broke
#384 took
changesets/actionv1.9.0 → v2.0.0. v2 renames every input, so the existingwith:block became invalid the moment it merged:Dependabot bumped a major action version while leaving the inputs untouched — the bump is a one-line SHA change, so nothing signalled that the call site needed rewriting.
Why v2 isn't just an input rename
Three things block it beyond the renames, from the v2.0.0 release notes:
@v1.apps/uiis on@changesets/cli2.31.0, so v2 would refuse regardless of how the inputs are written.cwdwas removed. This monorepo depends on it —.changeset/lives inapps/ui, not the repo root. There is no root-level changesets setup for the action to find.CHANGESETS_OUTPUT. Published-package detection moved from stdout parsing to a shared output file, and ourversion/publishare custom (bunx changeset version/bunx changeset tag).So this is a deliberate piece of work alongside the CLI v3 upgrade, not a dependency bump. The ignore entry mirrors
@astrojs/cloudflareandelysia-rate-limit, both held back for the same reason: a major that needs a migration we haven't done.Why PR CI didn't catch it
apps-ui-release.ymlonly runs on push tomain. No PR-triggered workflow exercises it, so a broken release config cannot fail a PR — it can only fail after merge. I flagged this action as unverified in #384's description but still let it into the batch; I should have checked the CLI-version constraint before including it, since the release notes state it plainly.Worth considering separately: a lint step that diffs an action's declared inputs against its
with:block would catch this class of failure at PR time. Happy to open an issue if you want it tracked.Test plan
mainran at7ebe038(pre-chore(deps): batch the post-#361 Dependabot wave #384) — verified withgit show 7ebe038:.github/workflows/apps-ui-release.ymlwith:inputs are unchanged, so the call site matches v1.9.0's contract againdependabot.ymlparses; the new entry sits in thegithub-actionsecosystem blockreleaseworkflow goes green on the merge commit — this is the real confirmation, and it can only be observed after mergeNo app code touched;
bun run checksurface is unaffected.Conventions
any/as/!— no TypeScript changedScreenshots
Not applicable.