Repository navigation
Conversation
Contributor
|
Can we call this Overall for this type of thing I'm not sure if we need a separate crate. It's fine by me if the utils live in timezone_provider for now. |
Member
Author
|
I'm fine with I'd prefer not to have these solely in timezone_provider. It gets a bit confusing at times and it makes them unavailable for use in the zoneinfo crate. |
Contributor
|
Okay, fair enough! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to primarily separate the date utils from living in the
timezone_provider.