Repository navigation
Migrate the FFI bindings from temporal_rs to temporal - #753
Merged
Merged
Conversation
Manishearth
approved these changes
Oct 20, 2026
Manishearth
left a comment
Contributor
There was a problem hiding this comment.
I misunderstood what you meant about renaming but this is fine.
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Oct 21, 2026
temporal_rs is renaming to temporal, including the namespaces and header paths boa-dev/temporal#753 This updates the code to prepare for that migration. Once the migration lands, I will land a cleanup removing these bridges. Change-Id: I18167ab56762d238457498cba38611d82071a4ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8622118 Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Manish Goregaokar <manishearth@google.com> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#111036}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #752. Migrate the FFI bindings to the new name.