Repository navigation
Fix zoneinfo parsing and add more comprehensive testing - #751
Merged
Merged
Conversation
Manishearth
approved these changes
Oct 20, 2026
Manishearth
left a comment
Manishearth
left a comment
Contributor
There was a problem hiding this comment.
This seems to be mixing architectural fixes with behavior fixes and is kind of hard to follow (I'm not familiar with all the bugs being fixed).
But the zoneinfo stuff is experimental so I'm fine just merging. It overall seems all positive
Member
Author
|
Yeah, sorry 😅 the gitignore was stale after the merge. There's bug fixes, but for 100% certainty I wanted to increase the coverage on the crate. |
nekevss
enabled auto-merge (squash)
October 21, 2026 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #602
This PR is going to be pretty massive but it fixes some of the remaining bugs when handling zoneinfo parsing and fixes a longstanding bug with the compiled time zone data from
zoneinfo.It also reworks the integration test for
zoneinfoand tests against the entire tzdb database.EDIT: Also, I've been using mise/nushell a decent amount at work recently, so I've added that into the workflow here 😅