Skip to content

fix(deploy): the Strimzi helm install skips the CRDs kates deploy already applied #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmscomp wants to merge 1 commit into from
Closed

fix(deploy): the Strimzi helm install skips the CRDs kates deploy already applied #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cli/cmd/deploy_components.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,8 +782,12 @@ func deployGroupA(dc *deployContext) error {
//
// --reset-values: pre-chart releases stored flat upstream keys that
// now live under the subchart key, and the schema rejects them.
//
// --skip-crds: applyLocalStrimziCRDs already applied them as the
// "kubectl" field manager; Helm 4 re-applying crds/ on a fresh
// install conflicts with it over .spec.versions.
opArgs := []string{"upgrade", "--install", "strimzi-operator", chartDir, "-n", "strimzi-operator",
"--reset-values",
"--reset-values", "--skip-crds",
"-f", dc.chartOverlay("charts/strimzi-operator"),
"--set", "strimzi-kafka-operator.kubernetesServiceDnsDomain=" + clusterDomain,
"--set", "crdUpgrade.enabled=false"}
Expand Down
1 change: 1 addition & 0 deletions cli/cmd/deploy_components_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,7 @@ func TestDeployGroupAAppliesLocalStrimziCRDsAndDisablesHook(t *testing.T) {
for _, want := range []string{
"upgrade --install strimzi-operator /cache/wrapper/1.2.0",
"--set crdUpgrade.enabled=false",
"--skip-crds",
"--set strimziVersion=1.2.0",
"--set strimzi-kafka-operator.kubernetesServiceDnsDomain=cluster.test",
} {
Expand Down
Loading