feat(channels): support project-home channel surfaces - #6594
feat(channels): support project-home channel surfaces#6594thomaspblock wants to merge 4 commits into
Conversation
Teach the shared channel shell to identify project homes, host an idle auxiliary surface, and present project-aware channel chrome without changing normal channel behavior. Signed-off-by: Thomas Petersen <thomasp@squareup.com>
…nel-first-pt3-channel-shell Signed-off-by: Thomas Petersen <thomasp@squareup.com>
Bring the channel-shell stack onto the verified project creation and authority fixes before evaluating Part 3 behavior. Co-authored-by: Wrench <0eabe6ea5758c1e4c5b68cea4ac42b32c479072883cb28da8110b4a47c32b9a1@buzz.block.builderlab.xyz> Signed-off-by: Wrench <0eabe6ea5758c1e4c5b68cea4ac42b32c479072883cb28da8110b4a47c32b9a1@buzz.block.builderlab.xyz>
Cassandra security/adversarial review — needs workReviewed the complete Part 3 diff and traced project enumeration through P1 — Any member can spoof an arbitrary channel as a project home (confidence: 100)Evidence
The value being trusted comes directly from the project signer's own presentation metadata:
A listed It also contradicts the stack's newly established rule in #6590: a project's Concrete trigger: Mallory publishes a listed Required direction: derive project-home classification from the same authoritative project↔repository↔channel relation used by the CLI/ACP base fixes (and fail closed on ambiguity), rather than from Residual riskI did not live-publish a hostile event to a shared relay. The code path is deterministic and the existing 5,422-test Desktop suite passes without covering this adversarial authority case. No other security finding survived review of this diff. |
Co-authored-by: Wrench <0eabe6ea5758c1e4c5b68cea4ac42b32c479072883cb28da8110b4a47c32b9a1@buzz.block.builderlab.xyz> Signed-off-by: Wrench <0eabe6ea5758c1e4c5b68cea4ac42b32c479072883cb28da8110b4a47c32b9a1@buzz.block.builderlab.xyz>
Cassandra security/adversarial re-review —
|
Gauge review residuals — head
|
Summary
This is Part 3 of the channel-first Projects stack, based on #6591. Part 4 adds the project-home navigation and context experience.
Testing
Post-Deploy Monitoring & Validation