Skip to content

test(desktop): survive early menu dismissals in the agent-voice spec #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maxwellimus wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −7
Open

test(desktop): survive early menu dismissals in the agent-voice spec #6530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions desktop/tests/e2e/huddle-transcription.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,17 +811,27 @@ test("assigns distinct agent voices and exposes compact per-agent controls", asy
});
expect(new Set(assignedVoices).size).toBe(2);

await page.getByRole("button", { name: "Voice settings for alice" }).click();
await waitForAnimations(page);
const voiceMenu = page.locator(
'[data-testid="huddle-agent-voice-menu-content"][data-state="open"]',
);
await expect(voiceMenu).toBeVisible();
await expect(
voiceMenu.getByText("Agent text-to-speech", { exact: true }),
).toBeVisible();
// Shortly after a cold load, background huddle-state settling re-renders
// the tiles and dismisses a just-opened Radix menu; in a fresh worker
// (which is also every CI retry) a single click fails deterministically.
// Retry the whole open-and-read unit until the menu holds through it.
const ttsToggle = voiceMenu.getByTestId("huddle-agent-tts-toggle");
await expect(ttsToggle).toBeChecked();
await expect(async () => {
if (!(await voiceMenu.isVisible())) {
await page
.getByRole("button", { name: "Voice settings for alice" })
.click();
}
await expect(voiceMenu).toBeVisible({ timeout: 1_500 });
await expect(
voiceMenu.getByText("Agent text-to-speech", { exact: true }),
).toBeVisible({ timeout: 1_500 });
await expect(ttsToggle).toBeChecked({ timeout: 1_500 });
}).toPass({ timeout: 20_000 });
await waitForAnimations(page);
await expect(
voiceMenu.getByTestId("huddle-agent-voice-selector"),
).toContainText("Vera");
Expand Down
Loading