fix(desktop): allow shared agent mentions by wesbillman · Pull Request #4913 · block/buzz

wesbillman · 2026-08-05T16:00:00Z

Summary

admit relay-discovered agents to autocomplete when their response policy authorizes the viewer
require authorization in the exact active stream/forum channel for mentions, while keeping community-wide discovery for member invitation
fail closed for relay-only agents in DMs and unresolved composer contexts
re-authorize cached autocomplete rows after policy/channel changes so stale agent suggestions cannot leak back in
preserve managed-agent behavior and explicitly reject stale agent-marked channel members absent from both live directories

Validation

pnpm --dir desktop test — 4,288 passed
pnpm --dir desktop typecheck
pnpm --dir desktop check
pnpm --dir desktop build:e2e
focused Playwright mention matrix — 12 passed
focused Playwright member-invitation matrix — 2 passed
pre-push hooks after rebase to current origin/main — desktop check and 4,288 tests passed
independent correctness/privacy re-review cleared with no remaining blocker

Related competing PRs

This supersedes or overlaps #2333, #3056, #4242, #4137, #2314, #4058, and #2605. This version adds exact-channel authorization, fail-closed DM/context handling, cached-row reauthorization, forum coverage, outbound mention-tag coverage, explicit stale-member coverage, and add-member discovery coverage.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>

Shipitrealgood · 2026-08-05T19:10:54Z

TY!

Pull main in before remediation, per Tyler's instruction: no rebase, no force, new commits on top. Co-authored-by: Sami <f4a42a97e594b77bdbd8ee35191c8b28a94a4cb871d96f32921558275421fb68@buzz.block.builderlab.xyz> Signed-off-by: Sami <f4a42a97e594b77bdbd8ee35191c8b28a94a4cb871d96f32921558275421fb68@buzz.block.builderlab.xyz> * origin/main: fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Polish mobile top navigation (#4778) fix(release): tag immutable desktop candidates (#4811) fix(channels): restrict private-channel invitations (#4612) fix(acp): reject unattended permission requests (#4609) fix(workflow): bind trigger author to the signed event (#4607) fix(git): revoke access for banned relay members (#4608) fix(agent): recover from unsupported image input instead of poisoning the turn (#4896) Define private managed agent wire protocol (#4593) fix(mobile): serialize channel sections sync (#3165) fix(desktop): make missing-command error actionable for released builds (#4802) Signed-off-by: Sami <f4a42a97e594b77bdbd8ee35191c8b28a94a4cb871d96f32921558275421fb68@buzz.block.builderlab.xyz>

…-overflow-recovery * origin/main: fix(buzz-agent): scope handoff cap per turn, not per session lifetime (#4805) Fix mobile message timeline bounce (#4862) Polish mobile bottom sheets and profile cards (#4911) Fix media attachment actions (#4849) fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Polish mobile top navigation (#4778) fix(release): tag immutable desktop candidates (#4811) fix(channels): restrict private-channel invitations (#4612) fix(acp): reject unattended permission requests (#4609) fix(workflow): bind trigger author to the signed event (#4607) fix(git): revoke access for banned relay members (#4608) fix(agent): recover from unsupported image input instead of poisoning the turn (#4896) Define private managed agent wire protocol (#4593) fix(mobile): serialize channel sections sync (#3165) fix(desktop): make missing-command error actionable for released builds (#4802) chore(release): release Buzz Desktop version 0.5.5 (#4809) feat: paste composer text without formatting (#4801) Revert "chore(release): release Buzz Desktop version 0.5.5" (#4808) chore(release): release Buzz Desktop version 0.5.5 (#4800) Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com> # Conflicts: # crates/buzz-agent/src/agent.rs # crates/buzz-agent/src/handoff.rs # crates/buzz-agent/src/types.rs # crates/buzz-agent/tests/regressions.rs

…usage * origin/main: fix(buzz-agent): scope handoff cap per turn, not per session lifetime (#4805) Fix mobile message timeline bounce (#4862) Polish mobile bottom sheets and profile cards (#4911) Fix media attachment actions (#4849) fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Polish mobile top navigation (#4778) fix(release): tag immutable desktop candidates (#4811) fix(channels): restrict private-channel invitations (#4612) fix(acp): reject unattended permission requests (#4609) fix(workflow): bind trigger author to the signed event (#4607) fix(git): revoke access for banned relay members (#4608) Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com>

…arer-auth * origin/main: (65 commits) fix(desktop): route macos notification clicks (#4799) feat(mobile): sync themes per community (#3767) feat(desktop): sync themes per community (#3653) feat(desktop): cap OpenClaw agent parallelism at 5 (#4019) fix(buzz-agent): scope handoff cap per turn, not per session lifetime (#4805) Fix mobile message timeline bounce (#4862) Polish mobile bottom sheets and profile cards (#4911) Fix media attachment actions (#4849) fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Polish mobile top navigation (#4778) fix(release): tag immutable desktop candidates (#4811) fix(channels): restrict private-channel invitations (#4612) fix(acp): reject unattended permission requests (#4609) fix(workflow): bind trigger author to the signed event (#4607) fix(git): revoke access for banned relay members (#4608) fix(agent): recover from unsupported image input instead of poisoning the turn (#4896) Define private managed agent wire protocol (#4593) fix(mobile): serialize channel sections sync (#3165) fix(desktop): make missing-command error actionable for released builds (#4802) ... Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com> # Conflicts: # CHANGELOG.md

…usage * origin/main: fix(buzz-agent): scope handoff cap per turn, not per session lifetime (#4805) Fix mobile message timeline bounce (#4862) Polish mobile bottom sheets and profile cards (#4911) Fix media attachment actions (#4849) fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Polish mobile top navigation (#4778) fix(release): tag immutable desktop candidates (#4811) fix(channels): restrict private-channel invitations (#4612) fix(acp): reject unattended permission requests (#4609) fix(workflow): bind trigger author to the signed event (#4607) fix(git): revoke access for banned relay members (#4608) Co-authored-by: Atish Patel <atish@squareup.com> Signed-off-by: Atish Patel <atish@squareup.com>

…ed-agent-store-merge * origin/main: (24 commits) fix(reactions): support max-length custom emoji (#3833) feat(desktop): allow leaving your final community (#3621) fix(buzz-agent): recover from context-window 400s instead of sticking (#4946) docs(persona-pack): fix stale desktop import instructions (#4500) fix(desktop): route macos notification clicks (#4799) feat(mobile): sync themes per community (#3767) feat(desktop): sync themes per community (#3653) feat(desktop): cap OpenClaw agent parallelism at 5 (#4019) fix(buzz-agent): scope handoff cap per turn, not per session lifetime (#4805) Fix mobile message timeline bounce (#4862) Polish mobile bottom sheets and profile cards (#4911) Fix media attachment actions (#4849) fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Polish mobile top navigation (#4778) fix(release): tag immutable desktop candidates (#4811) fix(channels): restrict private-channel invitations (#4612) fix(acp): reject unattended permission requests (#4609) fix(workflow): bind trigger author to the signed event (#4607) fix(git): revoke access for banned relay members (#4608) ... Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com> # Conflicts: # desktop/src-tauri/src/managed_agents/runtime.rs

…p-csp * origin/main: (66 commits) fix(reactions): support max-length custom emoji (#3833) feat(desktop): allow leaving your final community (#3621) fix(buzz-agent): recover from context-window 400s instead of sticking (#4946) docs(persona-pack): fix stale desktop import instructions (#4500) fix(desktop): route macos notification clicks (#4799) feat(mobile): sync themes per community (#3767) feat(desktop): sync themes per community (#3653) feat(desktop): cap OpenClaw agent parallelism at 5 (#4019) fix(buzz-agent): scope handoff cap per turn, not per session lifetime (#4805) Fix mobile message timeline bounce (#4862) Polish mobile bottom sheets and profile cards (#4911) Fix media attachment actions (#4849) fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Polish mobile top navigation (#4778) fix(release): tag immutable desktop candidates (#4811) fix(channels): restrict private-channel invitations (#4612) fix(acp): reject unattended permission requests (#4609) fix(workflow): bind trigger author to the signed event (#4607) fix(git): revoke access for banned relay members (#4608) ...

Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com> * origin/main: fix(reactions): support max-length custom emoji (#3833) feat(desktop): allow leaving your final community (#3621) fix(buzz-agent): recover from context-window 400s instead of sticking (#4946) docs(persona-pack): fix stale desktop import instructions (#4500) fix(desktop): route macos notification clicks (#4799) feat(mobile): sync themes per community (#3767) feat(desktop): sync themes per community (#3653) feat(desktop): cap OpenClaw agent parallelism at 5 (#4019) fix(buzz-agent): scope handoff cap per turn, not per session lifetime (#4805) Fix mobile message timeline bounce (#4862) Polish mobile bottom sheets and profile cards (#4911) Fix media attachment actions (#4849) fix(desktop): remove join API token control (#4897) fix(desktop): allow shared agent mentions (#4913) Signed-off-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz>

iroiro147 · 2026-08-06T08:20:02Z

Thanks for landing this @wesbillman — shared-agent mentions resolve correctly now.

One note on attribution: #4058 was open against #3971 from 1 Aug until I closed it today, and it documented this exact root cause — addCandidate filtered isAgent candidates against the local managed-agent list before shouldHideAgentFromMentions could run, which left the shared relay-agent eligibility path unreachable. This PR resolves it the same way, replacing that gate with isAgentIdentityInAllowedList(candidate, mentionableAgentPubkeys) backed by getMentionableAgentPubkeys. If #4058 informed the fix, a credit line would be appreciated. If you arrived at it independently, no concern at all — I've closed #4058 as superseded either way.

Separately: #3971 still appears open and looks resolved by this PR.

Conflict resolutions, upstream-as-default: - kind.rs: union — upstream KIND_PRIVATE_MANAGED_AGENT (30179) + fork KIND_SWARM/KIND_COMMUNITY_GUIDE (30978/30979); no integer clash. - migration.rs: MIGRATOR len 30; upstream 0028_long_reaction_payloads at [27], fork agent_invites/agent_member_role renumbered 0029/0030 (prep commit 29618eb) at [28]/[29]. - useMentions.ts: fork's buildMentionCandidates extraction kept; upstream block#4913 ported into it (scope-aware eligibility, isAgentIdentityInAllowedList, uniqueAutocompleteLabels, filterCachedAgentSuggestions). - buildMentionCandidates.ts: block#4913 gate adopted for NON-members; the fork's member bypass stays — relay-vetted member agents (invite-flow standalone agents) remain mentionable. Deliberate divergence from upstream, which hides members absent from managed+relay directories. - MembersSidebar.tsx: fork's 3-arg useClassifiedMembers (profiles overlay) kept over upstream's duplicate; upstream's add-dialog eligibility gate adopted with verifiedAgentPubkeys wired from search results so verified standalone agents stay addable. - ChannelScreen.tsx: fork's useChannelComposerTargets kept; upstream block#4965 clamp (useElementWidth before useThreadPanelWidth) arrived via auto-merge. - mentions.spec.ts: fork's member-agent mentionability test kept over upstream's opposite-assertion test; divergence comment added. Verified: tsc, desktop unit suite (4558), buzz-db/buzz-core/buzz-cli tests, cargo check -p buzz-acp, cargo fmt. Signed-off-by: kbst9 <kevinbsteiner@gmail.com>

The upstream merge (b25a1dd) committed unresolved conflict markers in useMentions.ts. Take the upstream side: isAgentIdentityInManagedList no longer exists, and upstream's isAgentIdentityInAllowedList against mentionableAgentPubkeys (which includes invocable relay agents) covers the case the local fork fix was protecting (superseded by upstream PR block#4913). Signed-off-by: Chad Arimura <chad@pinealpha.com>

…lock#5363) Merge kind:30177 respond_to policy and kind:39002 channel membership into list_relay_agents so block#4913 mention gates see production data (kind:10100 profiles are sparse). Add channel-member bot fallback in useMentions when directory channel_ids lag behind live membership. Signed-off-by: Roberto <roberto@infinitek.pe>

…lock#5363) Merge kind:30177 respond_to policy and kind:39002 channel membership into list_relay_agents so block#4913 mention gates see production data (kind:10100 profiles are sparse). Add channel-member bot fallback in useMentions when directory channel_ids lag behind live membership. Signed-off-by: Roberto <roberto@infinitek.pe> Signed-off-by: Roberto Michelena <77797875+rmichelena@users.noreply.github.com>

…lock#5363) Merge kind:30177 respond_to policy and kind:39002 channel membership into list_relay_agents so block#4913 mention gates see production data (kind:10100 profiles are sparse). Add channel-member bot fallback in useMentions when directory channel_ids lag behind live membership. Signed-off-by: Roberto Michelena <77797875+rmichelena@users.noreply.github.com>

## Summary - admit relay-discovered agents to autocomplete when their response policy authorizes the viewer - require authorization in the exact active stream/forum channel for mentions, while keeping community-wide discovery for member invitation - fail closed for relay-only agents in DMs and unresolved composer contexts - re-authorize cached autocomplete rows after policy/channel changes so stale agent suggestions cannot leak back in - preserve managed-agent behavior and explicitly reject stale agent-marked channel members absent from both live directories ## Validation - `pnpm --dir desktop test` — 4,288 passed - `pnpm --dir desktop typecheck` - `pnpm --dir desktop check` - `pnpm --dir desktop build:e2e` - focused Playwright mention matrix — 12 passed - focused Playwright member-invitation matrix — 2 passed - pre-push hooks after rebase to current `origin/main` — desktop check and 4,288 tests passed - independent correctness/privacy re-review cleared with no remaining blocker ## Related competing PRs This supersedes or overlaps block#2333, block#3056, block#4242, block#4137, block#2314, block#4058, and block#2605. This version adds exact-channel authorization, fail-closed DM/context handling, cached-row reauthorization, forum coverage, outbound mention-tag coverage, explicit stale-member coverage, and add-member discovery coverage. Signed-off-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz> Signed-off-by: bhargavms <bhargav.m@ewa-services.com>

…-agents-nav * origin/main: fix(desktop): allow shared agent mentions (block#4913) Polish mobile top navigation (block#4778) fix(release): tag immutable desktop candidates (block#4811) fix(channels): restrict private-channel invitations (block#4612) fix(acp): reject unattended permission requests (block#4609) fix(workflow): bind trigger author to the signed event (block#4607) fix(git): revoke access for banned relay members (block#4608) fix(agent): recover from unsupported image input instead of poisoning the turn (block#4896) Define private managed agent wire protocol (block#4593) fix(mobile): serialize channel sections sync (block#3165) fix(desktop): make missing-command error actionable for released builds (block#4802) chore(release): release Buzz Desktop version 0.5.5 (block#4809) feat: paste composer text without formatting (block#4801) Revert "chore(release): release Buzz Desktop version 0.5.5" (block#4808) chore(release): release Buzz Desktop version 0.5.5 (block#4800) Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>

## Summary - admit relay-discovered agents to autocomplete when their response policy authorizes the viewer - require authorization in the exact active stream/forum channel for mentions, while keeping community-wide discovery for member invitation - fail closed for relay-only agents in DMs and unresolved composer contexts - re-authorize cached autocomplete rows after policy/channel changes so stale agent suggestions cannot leak back in - preserve managed-agent behavior and explicitly reject stale agent-marked channel members absent from both live directories ## Validation - `pnpm --dir desktop test` — 4,288 passed - `pnpm --dir desktop typecheck` - `pnpm --dir desktop check` - `pnpm --dir desktop build:e2e` - focused Playwright mention matrix — 12 passed - focused Playwright member-invitation matrix — 2 passed - pre-push hooks after rebase to current `origin/main` — desktop check and 4,288 tests passed - independent correctness/privacy re-review cleared with no remaining blocker ## Related competing PRs This supersedes or overlaps block#2333, block#3056, block#4242, block#4137, block#2314, block#4058, and block#2605. This version adds exact-channel authorization, fail-closed DM/context handling, cached-row reauthorization, forum coverage, outbound mention-tag coverage, explicit stale-member coverage, and add-member discovery coverage. Signed-off-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>

…ests main's frontend mention gate (block#4913, block#6338) and backend list_relay_agents sourcing already fix the original bug this branch targeted, so those changes are dropped as superseded during this rebase. block#6338 added coverage for the owner-only-build variant, but the default-build path for a cross-owner relay agent with respond_to=anyone was still untested. Decouple the default relay-agent-directory fixture (alice/charlie) from the real human TEST_IDENTITIES pubkeys they coincidentally reused, extend the relay-agent mock seed to also register real channel bot membership, and add tests mirroring the exact reported repro: a bot member of a shared channel, owned by another identity, with respond_to=anyone, must be mentionable — and must stay hidden if it is only relay-directory-listed without real channel membership. Signed-off-by: oleg-ai-dev <oleg.ai.development@gmail.com>

wesbillman requested a review from a team as a code owner August 5, 2026 16:00

fix(desktop): allow shared agent mentions

fabbc9a

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz> Signed-off-by: Wes <wesbillman@users.noreply.github.com>

wesbillman force-pushed the carl/shared-agent-mention-eligibility branch from b7be47c to fabbc9a Compare August 5, 2026 17:24

wesbillman merged commit 014562c into main Aug 5, 2026
46 of 48 checks passed

wesbillman deleted the carl/shared-agent-mention-eligibility branch August 5, 2026 18:15

dcm-buzz-upstream-sync Bot mentioned this pull request Aug 5, 2026

Sync upstream Buzz 014562c063ea Divine-Creative-Ministries/buzz#14

Closed

radleynelson mentioned this pull request Aug 5, 2026

Product clarification: are shared agents intended to work across a Buzz community? #4941

Open

Shipitrealgood mentioned this pull request Aug 5, 2026

fix(desktop): decide mention eligibility for external agents from relay proofs #3676

Closed

4 tasks

cmyk mentioned this pull request Aug 5, 2026

fix(desktop): ingest remote-owned channel agents #4964

Open

dilate7 mentioned this pull request Aug 6, 2026

fix(desktop): mention live relay agents instead of re-instantiating personas #4635

Closed

iroiro147 mentioned this pull request Aug 6, 2026

fix(desktop): offer shared relay agents in @ mention autocomplete (#3971) #4058

Closed

cmyk mentioned this pull request Aug 6, 2026

fix(desktop): include external channel agents in mentions #4602

Closed

TheSeydiCharyyev mentioned this pull request Aug 6, 2026

fix(desktop): make owner-only relay agents mentionable by their owner #4839

Closed

Cvv9 mentioned this pull request Aug 6, 2026

Sync fork with upstream block/buzz (107 commits) Cvv9/buzz#17

Merged

marisgoerner-cell mentioned this pull request Aug 7, 2026

Bug: owner-reviewed agent drafts can leave orphan profiles without runnable records #5163

Open

kaalph mentioned this pull request Aug 7, 2026

Desktop drops relay-directory agents from the mention picker when it doesn't manage them locally #4776

Open

oceanseth mentioned this pull request Aug 7, 2026

Sync fork with block/buzz main (70 commits) oceanseth/buzz#2

Open

cscholly mentioned this pull request Aug 7, 2026

Shared Mini-hosted agents still not mentionable on 0.5.6 — no autocomplete chip, no p tag, agent never wakes #5240

Open

kvncrw mentioned this pull request Aug 7, 2026

feat(desktop): surface externally managed agents #5227

Closed

Open-luci mentioned this pull request Aug 8, 2026

Channel mention from a second owner device still mints a duplicate agent identity (desktop-v0.5.7, post-#4913) #5319

Open

Cyberworkshop mentioned this pull request Aug 9, 2026

Relay-discovered agent with respond_to=anyone still never appears in @-mention autocomplete (regression/incomplete case of #4913) #5363

Open

rmichelena mentioned this pull request Aug 10, 2026

fix(desktop): enrich relay agent directory for @mention eligibility (#5363) #5483

Closed

jjalora mentioned this pull request Aug 11, 2026

fix: publish kind:10100 agent directory records so shared agents are @-mentionable #5546

Open

akeemjenkins mentioned this pull request Aug 11, 2026

Agent identity and config need a home: execution pinned to the creating machine, edits routed to it #5583

Open

rmichelena mentioned this pull request Aug 13, 2026

External (non-desktop-managed) agents: publishing kind:10100 makes them un-mentionable — shouldHideAgentFromMentions's invocability logic is unreachable #2987

Open

micspiral mentioned this pull request Aug 13, 2026

Desktop: shared relay agents owned by other members are un-mentionable and un-addable (managed-list gate precedes directory eligibility) #2603

Open

dexsynccom mentioned this pull request Aug 13, 2026

feat(acp): publish kind:10100 agent directory profile #4713

Open

ScaleLeanChris mentioned this pull request Aug 13, 2026

fix(desktop): let channel-member agents reach the mention picker #5760

Closed

dyana1lyons-ai mentioned this pull request Aug 16, 2026

[Bug] Desktop 0.5.14 omits an authorized cross-owner bot member from @mention autocomplete #6022

Open

oleg-ai-dev mentioned this pull request Aug 24, 2026

fix(desktop): make cross-owner channel-member agents mentionable #4716

Open

Navigation Menu

Uh oh!

fix(desktop): allow shared agent mentions - #4913

fix(desktop): allow shared agent mentions#4913
wesbillman merged 1 commit into
mainfrom
carl/shared-agent-mention-eligibility

wesbillman commented Aug 5, 2026

Uh oh!

Uh oh!

Shipitrealgood commented Aug 5, 2026

Uh oh!

iroiro147 commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wesbillman commented Aug 5, 2026

Summary

Validation

Related competing PRs

Uh oh!

Uh oh!

Shipitrealgood commented Aug 5, 2026

Uh oh!

iroiro147 commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants