Repository navigation
feat(agents2): set no deadline on an agent's work - #874
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e0ffeb673
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // No deadline of our own: a turn runs until Codex ends it. | ||
| const signal = AbortSignal.any([entry.abort.signal, turnAbort.signal]); |
There was a problem hiding this comment.
Commit 21968c640956341347d8a370fc444051e3873bd0 has no Signed-off-by trailer in its raw commit message, so the repository's hosted DCO Check will fail even if the code checks pass. Recreate this commit with git commit --signoff before landing.
AGENTS.md reference: AGENTS.md:L194-L198
Useful? React with 👍 / 👎.
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
No changes requested. The two removed timers no longer cut off ongoing work; explicit agent-stop cancellation, turn completion/error cleanup, and handed-off-work settlement remain in place.
Star Lord automated source review via Wes’s account; head 7e0ffeb6730396dfc357547eb3c8f5526fc3146f, base 6eacd1336a798fa991b0937866bedaac2573fe3f. Source-only: inspected the implementation and regression tests; tests, app execution, and long-running native behavior were not validated.
baxen
changed the title
6eacd13 to
43cfd95
Compare
Buzz cut every Codex turn off after 29 minutes and stopped counting any handed-off run as working after 30, whether or not the agent was still going. A long Codex turn failed with "Codex could not finish: The operation timed out." Both limits are gone: a turn runs until the harness ends it, and the 👀/💬 reactions and local typing last as long as the work does. Removing an agent still stops its work. Co-authored-by: claude00 <fb8b76a01257932b8ca35060862c29bd09b2137638573731c2d5074fc02c5385@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Bradley Axen <baxen@squareup.com>
7e0ffeb to
16bfdda
Compare
2 participants
Top of the agents merge stack: #838 → #855 → #856 → #858 → #859 → #860 → #865 → #867 → #871 → this PR.
Buzz shouldn't put its own time limit on an agent's work. The harness can have one built in, but Buzz adds nothing on top. Before this PR, Buzz had two:
AbortSignal.timeout(29 * 60_000)in the Codex runtime). A long turn failed with "Codex could not finish: The operation timed out." even while it was still working. That's what cut codex00 off mid-push tonight.Changes
working()in the Agents service has no timer. Work counts as working until everything handed toworkingUntilsettles.Not changed
timeoutMsdeadline onrunis unchanged. Both harnesses return fromrunas soon as the turn is handed over, so it only covers that handover.thread/start, not to the turn.Testing
AbortSignal.timeoutalready expired still completes, and a mention's reactions survive two hours of handed-off work. Both fail without the fix.vitest runpasses: 580 files, 8247 tests. tsc and biome are clean.🤖 Generated with Claude Code