Skip to content

Add missing public css vars for selected icon of BitNav (#13637) - #13773

Open
msynk wants to merge 2 commits into
developfrom
msynk/13637-blazorui-nav-selected-item-icon
Open

msynk wants to merge 2 commits into
developfrom
msynk/13637-blazorui-nav-selected-item-icon

Conversation

@msynk

@msynk msynk commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

closes #13637

Summary by CodeRabbit

  • New Features
    • Nav items now support separate icon and description colors in hover, pressed, and selected states. State-specific colors can fall back to the item’s default colors, with pressed colors also able to fall back to hover colors.
  • Documentation
    • Updated the Nav CSS-variable reference with state-specific color options, defaults, and precedence rules.

@msynk
msynk requested a review from yasmoradi as a code owner October 11, 2026 12:34
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e6619c50-d445-4fa7-b66e-b42228363659

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e7d9a8dc-9a01-4f53-a1ff-ed1a5c74d886


📥 Commits

Reviewing files that changed from the base of the PR and between e09d4d2 and d4711fe.



📒 Files selected for processing (3)
  • src/BlazorUI/Bit.BlazorUI/Components/Navs/Nav/BitNav.scss
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Navs/Nav/BitNavDemo.razor.cs
  • src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Navs/Nav/BitNavStylesheetTests.cs


Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.




Walkthrough

BitNav adds state-specific icon and description color fallbacks for hover, pressed, and selected items. The demo documents the variables and their precedence. A stylesheet test checks the fallback chains.

Changes

BitNav state colors

Layer / File(s) Summary
State-specific color fallbacks
src/BlazorUI/Bit.BlazorUI/Components/Navs/Nav/BitNav.scss, src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Navs/Nav/BitNavDemo.razor.cs, src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Navs/Nav/BitNavStylesheetTests.cs
Hover, pressed, and selected items now pass icon and description color fallbacks to the accented-item mixin. Pressed colors fall back through hover colors before resting colors. The demo documents variable behavior and precedence, and the stylesheet test checks the fallback chains.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to d4711

No actionable merge-blocking issue is identified; the change is mergeable after normal checks.

Pre-merge checks | Passed 3 | Failed 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Out of Scope Changes check Warning The pull request also adds public pressed icon and description color variables, selected and hover description color variables, and related state behavior and documentation. Issue #13637 requests sele… Remove the unrelated pressed and description color variables, state behavior, documentation, and tests. Keep changes required for --bit-Nav-hover-icon-color and --bit-Nav-selected-icon-color, including their existing fallback and preced…
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately identifies the primary change: adding public CSS variables for the selected BitNav icon. The changes also cover hover, pressed, and description colors, but the title remains conci…
Linked Issues check Passed Issue #13637 requires public selected and hover icon color variables. BitNav.scss documents both variables and reads them before --bit-Nav-icon-color in the state color fallbacks. The selected and…


Full details: Out of Scope Changes check

Explanation

The pull request also adds public pressed icon and description color variables, selected and hover description color variables, and related state behavior and documentation. Issue #13637 requests selected and hover icon color variables. It does not request description color variables or a new pressed-color API. These changes extend the public API beyond the linked issue.

Resolution

Remove the unrelated pressed and description color variables, state behavior, documentation, and tests. Keep changes required for --bit-Nav-hover-icon-color and --bit-Nav-selected-icon-color, including their existing fallback and precedence behavior.



Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)




✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR



🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR



  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the nav at night
New icon shades glow clear and bright
Hover, press, select each find their hue
Descriptions get their colors too
The stylesheet tests the paths they take
Then hops away beneath the rake

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BitNav has no variable for the icon of the selected item

1 participant