Skip to content

fix: Path Traversal Safety for pybtc #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dewhush wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Path Traversal Safety for pybtc #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion setup_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ def download_library(command):
content = BytesIO(r.read())
content.seek(0)
with tarfile.open(fileobj=content) as tf:
# Prevent Tar Slip (Path Traversal)
base_path = os.path.realpath(os.getcwd())
for member in tf.getmembers():
member_path = os.path.realpath(os.path.join(base_path, member.name))
if not member_path.startswith(base_path + os.sep) and member_path != base_path:
raise Exception('Attempted Path Traversal in Tar File')
dirname = tf.getnames()[0].partition('/')[0]
tf.extractall()
shutil.move(dirname, libdir)
Expand Down Expand Up @@ -149,4 +155,4 @@ def detect_dll():
for fn in os.listdir(os.path.join(here, 'libsecp256k1')):
if fn.endswith('.dll'):
return True
return False
return False