Prevent plaintext from being inadventerly leaked in logs#147
Merged
Conversation
bincyber
force-pushed
the
fix/string-redaction
branch
from
392cd49 to
e7442ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a minor breaking change.
EncryptedBytes holds plaintext bytes after
Scan()and itsString()method returned them raw. Any inadvertent use infmt.Sprintf("%s", row), structured log fields, or error/panic formatting would leak the decrypted data.String()now returns "[REDACTED]".Plaintext()is added as an explicit method for callers that intentionally need the decrypted contents.