Fix panic due to invalid length ciphertext#144
Merged
Conversation
bincyber
force-pushed
the
fix/panic-ciphertext
branch
from
b9e245e to
84f4f22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto/cipher.AEAD.Open() panics when the nonce length is not NonceSize (12 bytes). bytes.Buffer.Next returns min(n, available), so a truncated ciphertext supplied via EncryptedBytes.Scan or UnmarshalJSON produces a short nonce and crashes the goroutine.
This PR adds explicit minimum-length checks and post-slice length assertions in both the kms and aesgcm providers' Decrypt() paths.
Go version has also been bumped to 1.26