Skip to content

fix: 小程序纯签约移除version参数 #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cofedream wants to merge 1 commit into
base: develop
Choose a base branch
from
+0 −15
Open

fix: 小程序纯签约移除version参数 #4073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions ...n-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxMaEntrustRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,21 +100,6 @@ public class WxMaEntrustRequest extends BaseWxPayRequest {
@XStreamAlias("notify_url")
private String notifyUrl;

/**
* <pre>
* 版本号
* sign
* 是
* string(8)
* 1.0
* 固定值1.0
* </pre>
*/
@Required
@XStreamAlias("version")

@augmentcode augmentcode Bot Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxMaEntrustRequest.java:114
本次变更会影响 maSign 生成的签名与输出参数，当前 WxEntrustPapServiceTest#testMaSign 没有断言（例如确认 json 中不再包含 version），可能难以及时发现回归。

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

private String version;

@augmentcode augmentcode Bot Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weixin-java-pay/src/main/java/com/github/binarywang/wxpay/bean/request/WxMaEntrustRequest.java:115
这里直接移除了 version 字段（@Data/@Builder 会对外暴露 getVersion/setVersion 及 builder 方法），对下游源码/二进制兼容是破坏性的；建议在发布说明/升级指引中明确该不兼容变更的影响范围。

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.



/**

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge 保留已发布的 version API

在已发布的 SDK 中直接删除 version 字段会同时移除 Lombok 生成的 getVersion/setVersion、WxMaEntrustRequestBuilder.version(...) 以及全参构造器参数；下游如果已经按旧 API 调用 .version("1.0")，升级这个补丁后会出现编译失败，已编译产物也可能在运行时遇到 NoSuchMethodError。这里可以保留并标记废弃兼容入口，同时确保它不再参与小程序纯签约的输出或签名。

Useful? React with 👍 / 👎.

* <pre>
* 时间戳
Expand Down