Wrong UI camera fix#24982
Open
ickshonpe wants to merge 4 commits into
Open
Conversation
… One of the nodes targets the non-default camera. Then after updating, parent the node without a camera target to the other node. Should both be targetting the non-default camera, but child stays targeting the default camera.
…ode. `update_context_after_parented` now passes.
ickshonpe
added
C-Bug
ickshonpe
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Jul 14, 2026
kfc35
approved these changes
Jul 14, 2026
kfc35
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24966
Solution
We're missing cleanup for the UI propagation components.
Remove the propagation components unless a UI node is a root.
Testing
Includes a test
update_context_after_parented.