Fix crash when adding ContactShadows to a camera at runtime#24977
Open
voidreamer wants to merge 1 commit into
Open
Fix crash when adding ContactShadows to a camera at runtime#24977voidreamer wants to merge 1 commit into
voidreamer wants to merge 1 commit into
Conversation
check_views_need_specialization read Has<ViewContactShadowsUniformOffset>, which is only inserted during PrepareResources, after the check has run. On a view's first frame with contact shadows the pipeline key missed CONTACT_SHADOWS while the bind group included binding 16, and wgpu's validation failure quit the app. Read the extracted ContactShadows instead, like the fog bit reads DistanceFog. Fixes bevyengine#24951.
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
kfc35
added
C-Bug
kfc35
approved these changes
Jul 14, 2026
kfc35
left a comment
kfc35
left a comment
Contributor
There was a problem hiding this comment.
Nice, thorough investigation. I agree with this solution; thanks for the time and thought you put into it, and sorry this caused a fuss for you and your team
kfc35
added
the
D-Straightforward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24951
Solution
Key the view's
CONTACT_SHADOWSbit off the extractedContactShadowscomponent instead ofViewContactShadowsUniformOffset, which is only inserted inPrepareResources, aftercheck_views_need_specializationhas already run. Same pattern as the other view key bits (DistanceFog, OIT, atmosphere).Testing
Ran the repro from #24951: crashes on main, runs clean with this change. Also removed and re-inserted
ContactShadowson a live camera, no validation errors either way.