Add warn_once to wgpu backend once case and add regression test#24976
Merged
alice-i-cecile merged 2 commits intoJul 14, 2026
Conversation
rewin123
added
C-Bug
robojeb
approved these changes
Jul 13, 2026
robojeb
left a comment
robojeb
left a comment
Contributor
There was a problem hiding this comment.
The changes in #24420 make it a little hard to verify in isolation that the resource PendingSyncEntity is sufficient to check for the non-existence of the RenderWorld.
As it makes it appear that SyncComponent is more generic than it actually is at this point in the implementation.
Having reviewed the surrounding code this seems good and should work well to ensure this is tested properly as the SyncComponent evolves in #24423
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Jul 14, 2026
Contributor
|
will this be part of 0.19.1? I've encountered this bug in the wild and would appreciate the fix - merci beaucoup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24927
Solution
Just add conditional check for PendingSyncEntity resource, when do remove component with registered SyncComponentPlugin.
Testing
I added one regression test. It fails on main branch and pass on my PR.