Skip to content

Solari: Add BLAS/TLAS build GPU spans#24955

Merged
alice-i-cecile merged 2 commits into
bevyengine:mainfrom
JMS55:solari7-as-gpu-timings
Jul 16, 2026
Merged

Solari: Add BLAS/TLAS build GPU spans#24955
alice-i-cecile merged 2 commits into
bevyengine:mainfrom
JMS55:solari7-as-gpu-timings

Conversation

@JMS55

@JMS55 JMS55 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Objective

  • Add GPU timing spans for BLAS and TLAS builds
  • Does not include BLAS compaction

Showcase

image

@JMS55 JMS55 added A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 11, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jul 11, 2026
@JMS55
JMS55 requested a review from SparkyPotato July 13, 2026 13:38
@JMS55 JMS55 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 14, 2026
@JMS55

JMS55 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

(iirc trivial PRs only need 1 reviewer, someone correct me if that's wrong)

JMS55
JMS55 commented Jul 14, 2026
View reviewed changes
Comment thread crates/bevy_render/src/diagnostic/mod.rs
);
render_app
.add_systems(
Render,

@JMS55 JMS55 Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is bad here, but all it's doing is moving begin_diagnostics_frame from RenderGraphSystems::Begin to between ExtractCommands and PrepareAssets, since BLAS builds are done in PrepareAssets.

@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Jul 16, 2026
Merged via the queue into bevyengine:main with commit 00d25fa Jul 16, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@stuartparmenter stuartparmenter stuartparmenter approved these changes
@SparkyPotato SparkyPotato SparkyPotato approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JMS55 @stuartparmenter @SparkyPotato @alice-i-cecile