Add Okhwba color space#24950
Open
tmstorey wants to merge 1 commit into
Open
Conversation
kfc35
reviewed
Jul 12, 2026
kfc35
left a comment
Contributor
There was a problem hiding this comment.
are you planning to do the gen_tests changes in this PR as well? the description mentions it but it’s not clear whether this PR is waiting for that
Beyond that, this PR looks mostly good except for the one thing re: testing okhsva <-> okhwba conversion I mentioned
| use crate::testing::assert_approx_eq; | ||
|
|
||
| #[test] | ||
| fn test_from_oklaba() { |
Contributor
There was a problem hiding this comment.
Instead of this being copied from okhsva as is, I would think there needs to be a thorough test like this one that ensures the conversion between okhwba and okhsva is as expected, since that’s the new logic implemented in this module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Bevy has multiple Ok color spaces and the HWB color space, but not the Okhwb color space. This would be good for consistency, and also useful for supporting triangular color pickers, such as an Ok color space version of the HWB picker in my other PR: #24917.
Solution
Okhwbacolor space struct, withnew,hwb,with_whitenessandwith_blacknessmethods.Debug,Clone,Copy,PartialEq,Reflect, and serialization.StandardColor,Default,Mix,Gray,Alpha,Hue,ColorToComponentsand variousFromimpls.Color::Okhwba(Okhwba)enum variant, andColor::okhwba()andColor::okhwb()constructors.Testing
Okhsva.gen_testsandTEST_COLORSnot yet implemented.Showcase
New conversion diagram: