FromTemplate derive macro visibility change#24941
Open
alphadragon2 wants to merge 1 commit into
Open
Conversation
… be the same as in the original.
IQuick143
added
A-Scenes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently, the visibility of member variables in the Template type created by the FromTemplate derive macro does not match the original type. instead, anything that is not
pubis downgraded back to private.This results in unexpected behaivor, where for example templates of that type cannot be used in different parts of the same crate, even if the original type has all member fields set to
pub(crate).Solution
Changed the visibility to simply copy the current visibility.
Testing
No testing beyond the included CI tests was performed.