Repository navigation
Fix preview errors - #661
Conversation
After replacing preview content, the editor removed the last .xCreateNewEntry in the page before dispatching addEntry. BertaEditor already replaces the link after the entries list on addEntry, so the removal was redundant, and it threw on pages without any such link (no entries list, messy grid view), which stopped addEntry from being dispatched. It also deleted the last entry's own link when the rerender ran before BertaEditor had added the one after the list. Rerenders now only dispatch addEntry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughPreview load polling now waits for a body and stops polling if navigation replaces the document. Rerender services now call ChangesPreview Load Polling
Backend Reload After Rerender
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change makes preview polling and rerender notifications more robust. No concrete merge-blocking issue was identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The event fires after every entries rerender (entry changes, settings, page layout), not only when an entry is added, and the function that dispatched it didn't reload anything. Name both after what happens, matching sitesMenuRerendered and sectionsMenuRerendered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary by CodeRabbit