Repository navigation
Drain redirect bodies without buffering, NEWS for #980 - #991
Merged
Merged
Conversation
Skipping a redirect body on the async path read it whole, so it held the body in memory and, since #980, stopped at max_body_size with the rest left unread. It now drops chunks as they arrive. The 512 MiB default is defined once in hackney.hrl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an async request hits a redirect, hackney skips the redirect's body. It did so by reading the whole body into memory; since #980 that read also stops at
max_body_sizeand leaves the rest of the body unread on the connection. The body is now dropped chunk by chunk, with no memory cost and no cap.The 512 MiB default is defined once in
hackney.hrlinstead of in bothhackney_connandhackney_h3, and NEWS gets the #980 entry. No behaviour change beyond the redirect drain.