Skip to content

fix: misidentified the connected user as the removed group member - #236

Merged
highesttt merged 1 commit into
mainfrom
highest/plat-38628
Aug 26, 2026
Merged

fix: misidentified the connected user as the removed group member#236
highesttt merged 1 commit into
mainfrom
highest/plat-38628

Conversation

@highesttt

Copy link
Copy Markdown
Collaborator

No description provided.

@linear-code

linear-code Bot commented Aug 26, 2026

Copy link
Copy Markdown

PLAT-38628

@indent

indent Bot commented Aug 26, 2026

Copy link
Copy Markdown
PR Summary

Fixes LINE member-removal (C_MR/A_MR) system-message handling, which misidentified msg.From (the remover) as the removed member. When the connected user removed someone, the bridge removed the connected user instead, causing the whole group chat to disappear from Beeper (PLAT-38628). The removed member is now taken from LOC_ARGS, and the leave is attributed to the removed member with the remover as the change sender. Later commits bump the Go toolchain to 1.26 and migrate a deprecated mautrix-go API so the updated linter passes.

  • Adds memberRemovalMIDs to derive the remover (msg.From) and the removed member (last distinct user MID in LOC_ARGS).
  • makeSystemMessageEvent emits the leave for the removed member with the remover as change sender, and evicts the correct cache entry; isHandledSystemMessage only accepts removal records carrying a valid removed user MID distinct from the remover.
  • Adds tests for attribution, cache eviction, and validation of malformed records.
  • Bumps Go to 1.26 (go.mod, deploy workflow, Dockerfile, AGENTS.md).
  • Migrates the deprecated ChatMemberList.Members slice to MemberMap via a new chatMemberMapFromList helper (create-group, DM/group resync, chat-info paths); behavior-preserving since both key by sender.
  • Suppresses staticcheck SA1019 on the required rsa.EncryptPKCS1v15 call used by LINE's login protocol.

Issues

Review closed.

CI Checks

All CI checks passed on 4a259e4.

@highesttt
highesttt merged commit 2c1fd56 into main Aug 26, 2026
9 checks passed
@highesttt
highesttt deleted the highest/plat-38628 branch August 26, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant