Repository navigation
Allow sourcing dirconfig settings from custom configuration files - #2200
Open
attilayener wants to merge 2 commits into
Open
attilayener wants to merge 2 commits into
attilayener wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2197
Problem
Projectile can only parse project settings from its own
.projectilefile. Projects that already carry a machine-readable configuration file
(e.g. an Eclipse
.project' XML) cannot feed it into Projectile - the user has to maintain the same information twice, and pointingprojectile-dirconfig-file' at such a file just makes the built-inparser choke on its contents.
Solution
As proposed in #2197, this adds
projectile-dirconfig-parsers: analist of configuration file names and parser functions. When a project
root has no
projectile-dirconfig-file', the parser of the first file from the list found in the root is called with the file's absolute path and must return aprojectile-dirconfig' structure (or nil).entry records the resolved file's path and mtime, so edits invalidate
it exactly like the built-in file
actually parsed from
doc/modules/ROOT/pages/ignoring.adoctest/projectile-ignore-test.el