Repository navigation
Recognise fd indexing commands by program name - #2190
Merged
Merged
Conversation
Alien indexing pushes the ignore rules down into the listing command, and picked the exclusion syntax by spotting `--strip-cwd-prefix' in the command and otherwise assuming any git project was listed by `git ls-files'. With `projectile-git-fd-args' customised without that flag, fd was handed `:(exclude,glob)' pathspecs, read them as search paths and failed with "No valid search paths given". The same check decided how dirconfig `+' directories are passed, so fd got them as a search pattern. The tool is now told apart by the program name (fd, fdfind, git, with the directory and any .exe dropped), keeping the flag as a fallback for an fd installed under another name. A command that is neither is filtered in Lisp, which is slower but always right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alien indexing told fd apart from
git ls-filesby the--strip-cwd-prefixflag, so an fd whoseprojectile-git-fd-argslacks it got git exclude pathspecs and died with "No valid search paths given". Dirconfig+directories were passed to it wrong for the same reason. A command that's neither fd nor git now gets filtered in Lisp instead of guessed at.Fixes #2187
eldev test)M-x checkdocwarnings