Bump to 3.2.0-snapshot and exercise ripgrep in CI#2083
Merged
Conversation
The 3.2.0 features already landing (sessions, tasks, file kinds, the reviewable search/replace UI, ...) stamp their defcustoms with :package-version 3.2.0, but the Version header and projectile-version were still 3.1.0. Bump them so the metadata is consistent.
Install ripgrep in the CI test job so the search reviewer's rg fast-path is actually exercised (the specs self-skip when rg is absent). Add a parity spec asserting the rg fast-path and the portable elisp scan return the same match set over a shared fixture - the core correctness claim of the fast-path, previously only tested per-branch. Enabling rg in CI also surfaced a flaky wait helper: the pre-existing rg specs pumped `accept-process-output' on the scan *process*, which returns immediately once that process has exited without dispatching its queued sentinel - so `projectile-search--rg-finish' never ran and the scan flag never cleared (hung on Emacs 28.2). Pump the general event loop instead.
bbatsov
force-pushed
the
chore/3.2-dev-version-and-rg-ci
branch
from
8ac340f to
3002b98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bits of 3.2 dev-cycle housekeeping.
Version metadata. The 3.2.0 features already on
masterstamp their defcustoms with:package-version 3.2.0, but theVersion:header andprojectile-versionstill said3.1.0. Bumped both to3.2.0-snapshotso the metadata is consistent (the reviewers flagged the mismatch).ripgrep in CI. Install
rgin the test job so the search reviewer's ripgrep fast-path specs actually run (they self-skip whenrgis absent). Added a parity spec asserting the rg fast-path and the portable elisp scan return the same match set over a shared fixture - the core correctness claim of9bea34e, previously only tested per-branch. Verified locally against a realrg.889 specs, clean
--warnings-as-errors.