Repository navigation
Fix gRPC CI pipeline and Windows HTTP config quoting - #2984
Open
meteorcloudy wants to merge 1 commit into
Open
meteorcloudy wants to merge 1 commit into
meteorcloudy wants to merge 1 commit into
Conversation
meteorcloudy
requested review from
fweikert and
ted-xie
and removed request for
a team
November 2, 2026 15:18
meteorcloudy
force-pushed
the
fix-grpc-ci
branch
from
November 3, 2026 10:01
950e877 to
a0a4103
Compare
Member
|
Could we also add |
## Problem The gRPC pipeline fails on Windows, macOS arm64, and Ubuntu 22.04 LTS: - On Windows, `shlex.quote` wraps `--http_config` URLs that contain query parameters in single quotes, which `cmd.exe` does not strip, causing `urllib.request.urlopen` to reject the URL. - gRPC's `tools/bazel` wrapper overrides `USE_BAZEL_VERSION` with `.bazelversion` on Linux and macOS, and fails on Windows. - On macOS arm64 and Windows, the CI job does not exclude Linux-only (`no_mac`) or Windows-incompatible (`no_windows`, `grpc-fuzztest`) targets. - On Ubuntu 22.04 LTS, Clang 14 with GCC 11 `libstdc++` fails header parsing in C++17 mode with `-Winvalid-partial-specialization`. ## Solution - Quote runner command arguments on Windows using double quotes with `.bat` and MSVC UCRT escaping (`""`, doubled backslashes before quotes, and `%%`), and reject embedded newlines or NUL bytes. - Set `BAZELISK_SKIP_WRAPPER: "true"` for all tasks in `pipelines/grpc.yml`. - Add platform-specific `--build_tag_filters` and `--test_tag_filters` flags in `pipelines/grpc.yml`, and suppress `-Wno-invalid-partial-specialization` on Linux.
meteorcloudy
force-pushed
the
fix-grpc-ci
branch
from
November 6, 2026 14:49
a0a4103 to
dde13cd
Compare
Member
Author
|
Done — added |
fraso20203030-lab
approved these changes
Nov 8, 2026
fraso20203030-lab
approved these changes
Nov 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The gRPC pipeline fails on Windows, macOS arm64, and Ubuntu 22.04 LTS:
shlex.quotewraps--http_configURLs that contain query parameters in single quotes, whichcmd.exedoes not strip, causingurllib.request.urlopento reject the URL.tools/bazelwrapper overridesUSE_BAZEL_VERSIONwith.bazelversionon Linux and macOS, and fails on Windows.no_mac) or Windows-incompatible (no_windows,grpc-fuzztest) targets.libstdc++fails header parsing in C++17 mode with-Winvalid-partial-specialization.Solution
.batand MSVC UCRT escaping ("", doubled backslashes before quotes, and%%), and reject embedded newlines or NUL bytes.BAZELISK_SKIP_WRAPPER: "true"for all tasks inpipelines/grpc.yml.--build_tag_filtersand--test_tag_filtersflags inpipelines/grpc.yml, and suppress-Wno-invalid-partial-specializationon Linux.