Repository navigation
Conversation
Configuring a Python patch version newer than the built-in `MINOR_MAPPING` failed in the `python` and `pip` Bzlmod extensions. Manifest files loaded via `add_runtime_manifest_files` omitted the release tag from default download URLs, `single_version_override` did not require `sha256` and `urls` when introducing a new version, and `pip.parse` failed to match host interpreters when toolchain and pip version granularities differed (such as `X.Y` vs. `X.Y.Z` or versions inferred from `pyproject.toml`). Update the `python` extension to include the release build version in default manifest URLs, require `sha256` and `urls` for new single-version overrides, and verify requested toolchains exist in `tool_versions`. Update `pip.parse` to resolve host interpreters across exact, full, and `major.minor` version names and key index URL settings by the resolved Python version. Fixes bazel-contrib#4358
Collaborator
Author
|
AI Disclosure
This is an automatically generated agent comment. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuring a Python patch version newer than the built-in
MINOR_MAPPINGfailed in thepythonandpipBzlmod extensions.Manifest files loaded via
add_runtime_manifest_filesomitted therelease tag from default download URLs,
single_version_overridedidnot require
sha256andurlswhen introducing a new version, andpip.parsefailed to match host interpreters when toolchain and pipversion granularities differed (such as
X.Yvs.X.Y.Zor versionsinferred from
pyproject.toml).Update the
pythonextension to include the release build version indefault manifest URLs, require
sha256andurlsfor newsingle-version overrides, and verify requested toolchains exist in
tool_versions. Updatepip.parseto resolve host interpreters acrossexact, full, and
major.minorversion names and key index URL settingsby the resolved Python version.
Fixes #4358