Repository navigation
refactor(examples): migrate remaining lockfiles to uv lock() - #4365
Merged
Merged
Conversation
Now that the `uv` `lock()` macro supports `WORKSPACE` builds, remaining non-dedicated `compile_pip_requirements` targets and `pip-compile` lockfiles can use `uv` instead. Migrate `tests/multiple_inputs` to `lock()` with `diff_test`, register `uv` toolchains in the example `WORKSPACE` and `MODULE.bazel` files, and regenerate the example `requirements*.txt` files with `uv`.
Collaborator
Author
|
AI Disclosure:
This is an automatically generated agent comment. |
dougthor42
approved these changes
Oct 27, 2026
dougthor42
left a comment
Collaborator
There was a problem hiding this comment.
Should we keep some non-uv examples in case people want slow stuff? Or in case uv becomes enshittified and people want to switch back?
Collaborator
Author
|
I think we should keep the docs and tests as long as we support it. I'm torn about what compile_pip_requirement's future is, though. I like the idea of supporting all the different lockers (pycross supports some other lockers), however, we need owners who are interested in supporting them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the
uvlock()macro supportsWORKSPACEbuilds, remainingnon-dedicated
compile_pip_requirementstargets andpip-compilelockfiles can use
uvinstead.Migrate
tests/multiple_inputstolock()withdiff_test, registeruvtoolchains in the exampleWORKSPACEandMODULE.bazelfiles, andregenerate the example
requirements*.txtfiles withuv.