Repository navigation
agents: refine Starlark data serialization, docstring, and WORKSPACE rules - #4364
Merged
rickeylev merged 1 commit intoOct 27, 2026
Merged
Conversation
…rules Capture review feedback from bazel-contrib#4360 in the workspace agent rules so future Starlark and WORKSPACE implementations follow the same patterns: - Direct repository rules to serialize JSON-compatible data constants in generated `.bzl` files with `json.encode_indent()` instead of custom `render.*` helpers. - Keep `.bzl` API docstrings brief and place multi-scenario examples and setup guides in narrative `docs/` pages linked via `{ref}` or `{obj}`. - Require `WORKSPACE` macros to match Bzlmod extension defaults, tag schemas, and single-hub multi-version structure, splitting manifest downloads into a manifest repo rule and a bound registration macro.
Collaborator
Author
|
AI Disclosure
This is an automatically generated agent comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture review feedback from #4360 in the workspace agent rules so
future Starlark and WORKSPACE implementations follow the same patterns:
generated
.bzlfiles withjson.encode_indent()instead of customrender.*helpers..bzlAPI docstrings brief and place multi-scenario examples andsetup guides in narrative
docs/pages linked via{ref}or{obj}.WORKSPACEmacros to match Bzlmod extension defaults, tagschemas, and single-hub multi-version structure, splitting manifest
downloads into a manifest repo rule and a bound registration macro.