Repository navigation
workflows: harden GitHub Actions YAML against injection - #4361
Merged
rickeylev merged 1 commit intoOct 27, 2026
Merged
Conversation
Interpolating GitHub Actions expressions directly into shell `run:` blocks, `actions/github-script` scripts, and `.bazelrc` configs risks command, script, or flag injection when inputs or refs contain shell metacharacters, newlines, or leading hyphens. Pass workflow inputs and context values through step-scoped `env:` variables, sanitize branch names written to `.bazelrc`, use `printf '%s\n'` instead of `echo`, and guard CLI arguments with `--flag=value` or `--` separators. Also require `parse_comment` to succeed before posting failure reactions on issue comments.
Collaborator
Author
|
AI Disclosure: This PR was prepared with the assistance of an AI coding agent operating in a This is an automatically generated agent comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interpolating GitHub Actions expressions directly into shell
run:blocks,
actions/github-scriptscripts, and.bazelrcconfigs riskscommand, script, or flag injection when inputs or refs contain shell
metacharacters, newlines, or leading hyphens.
Pass workflow inputs and context values through step-scoped
env:variables, sanitize branch names written to
.bazelrc, useprintf '%s\n'instead ofecho, and guard CLI arguments with--flag=valueor--separators. Also requireparse_commenttosucceed before posting failure reactions on issue comments.