refactor(zipapp): implement rust exe_zip_maker program - #4151
Open
rickeylev wants to merge 2 commits into
Open
Conversation
Provide a compiled Rust implementation of exe_zip_maker to replace the Python script for creating self-executable zip archives. - Implement exe_zip_maker library and CLI binary in crates/exe_zip_maker - Use sha2 crate via crate_universe for SHA-256 computation - Add distribution filegroups and tests in tests/exe_zip_maker
WORKSPACE mode fails when expanding wildcard patterns because @rules_rust is only configured in Bzlmod. Provide a stub repository for rules_rust in internal_dev_deps.bzl and set size = "small" on exe_zip_maker_test.
rickeylev
marked this pull request as ready for review
September 7, 2026 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating self-executable zip archives currently relies on Python script
execution during builds, which incurs interpreter startup overhead and
requires a Python runtime.
Provide a compiled Rust implementation of exe_zip_maker. The tool
computes the SHA-256 digest of the input zip archive, substitutes the
%ZIP_HASH% placeholder within the executable preamble script, and
concatenates the modified preamble with the zip payload.
This change only adds a Rust implementation. Subsequent changes will
wire it into the overall build process as a prebuilt tool.