Repository navigation
frr_ospf_max_metric_router_lsa: point main-RIB sickbay at #10458 now that #10452 landed - #250
Merged
Merged
Conversation
…that #10452 landed With batfish/batfish#10452 merged, Batfish matches the device on every OSPF route except the three to abr1's loopback, which Batfish still maxes (batfish/batfish#10458). The main-RIB sickbay on r0, r1, and abr2 now cites that issue. ---- Prompt: ``` PR was merged, and the author updated their PR as well ```
dhalperi
enabled auto-merge (squash)
October 28, 2026 05:37
dhalperi
disabled auto-merge
October 28, 2026 05:37
dhalperi
enabled auto-merge (squash)
October 28, 2026 05:37
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 97 97
Lines 4527 4527
=======================================
Hits 3752 3752
Misses 775 775
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With batfish/batfish#10452 merged, Batfish matches the device on every
OSPF route except the three to abr1's loopback, which Batfish still
maxes (batfish/batfish#10458). The main-RIB sickbay on r0, r1, and
abr2 now cites that issue.
Prompt: