Repository navigation
frr: add containerlab FRR lab builder support, FrrValidator, and frr_ospf_max_metric_router_lsa lab - #249
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 82.90% 82.88% -0.03%
==========================================
Files 96 97 +1
Lines 4515 4527 +12
==========================================
+ Hits 3743 3752 +9
- Misses 772 775 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ospf_max_metric_router_lsa lab Add an FRR (containerlab frr kind) vendor profile to lab_builder. The containerlab-<version> image runs sshd; lab_builder logs in as root with ~/.ssh/id_ed25519, which ec2-setup.sh now creates and copies where containerlab authorizes it. build-snapshot wraps the collected running config in the Cumulus concatenated format, the only way Batfish reads FRR outside SONiC. Add FRR OSPF health and interface checks, reuse the SONiC vtysh BGP and route checks, and add a route_next_hops check for a route's next hops and metric. wait_for_ssh now fails at once on netmiko argument errors instead of retrying until the boot timeout, and health checks treat a stopped bgpd or ospfd as unconfigured. Add FrrValidator for FRR 10: per-VRF route JSON, eth0 excluded, and FRR 10 local routes excluded (#248). SonicValidator now extends it. Add frr_ospf_max_metric_router_lsa, four FRR 10.7.1 routers with "max-metric router-lsa administrative" on one of two ABRs. The main RIB is sickbayed on r0, r1, and abr2 for batfish/batfish#7073. With batfish/batfish#10452 the remaining mismatch is the max-metric ABR's loopback, which FRR advertises at its interface cost. Interface properties are sickbayed for #43. ---- Prompt: ``` Review batfish/batfish#10452 Can we create a lab for it? ``` Follow-ups: use plain FRR containers rather than Cumulus; exclude FRR 10 local routes in FrrValidator and file a lab-validation issue; debug the SSH and health-check stalls before opening the PR.
dhalperi
force-pushed
the
frr-ospf-max-metric-router-lsa
branch
from
October 28, 2026 01:23
33566ee to
fdf0c83
Compare
dhalperi
enabled auto-merge (squash)
October 28, 2026 01:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an FRR (containerlab frr kind) vendor profile to lab_builder. The
containerlab- image runs sshd; lab_builder logs in as root
with ~/.ssh/id_ed25519, which ec2-setup.sh now creates and copies where
containerlab authorizes it. build-snapshot wraps the collected running
config in the Cumulus concatenated format, the only way Batfish reads
FRR outside SONiC. Add FRR OSPF health and interface checks, reuse the
SONiC vtysh BGP and route checks, and add a route_next_hops check for
a route's next hops and metric. wait_for_ssh now fails at once on
netmiko argument errors instead of retrying until the boot timeout,
and health checks treat a stopped bgpd or ospfd as unconfigured.
Add FrrValidator for FRR 10: per-VRF route JSON, eth0 excluded, and
FRR 10 local routes excluded (#248).
SonicValidator now extends it.
Add frr_ospf_max_metric_router_lsa, four FRR 10.7.1 routers with
"max-metric router-lsa administrative" on one of two ABRs. The main
RIB is sickbayed on r0, r1, and abr2 for batfish/batfish#7073. With
batfish/batfish#10452 the remaining mismatch is the max-metric ABR's
loopback, which FRR advertises at its interface cost. Interface
properties are sickbayed for #43.
Prompt:
Follow-ups: use plain FRR containers rather than Cumulus; exclude FRR
10 local routes in FrrValidator and file a lab-validation issue; debug
the SSH and health-check stalls before opening the PR.