Repository navigation
ci: consolidate required checks - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates PR CI after merged #45 without changing runtime/evidence semantics.
Workflow cleanup
.github/workflows/ci.ymland.github/workflows/publish.yml;.github/workflows/native-observer-integration.yml;.github/workflows/runtime-evidence-acceptance.yml;testandruntime-integration.testRuns on every PR and keeps fast/general checks only:
It no longer builds the real OpenCode or Copilot runtime images.
runtime-integrationThe job exists on every PR. It decides applicability internally, so documentation-only/unrelated PRs still receive a successful
runtime-integrationcheck instead of a missing required check.For runtime-relevant changes it:
This removes the prior three-way rebuild of the same stock OpenCode image on runtime PRs.
Dead code cleanup
Confirmed
loaded_skills_from_exportandassistant_from_exporthave no production/runtime/runner/documented caller on currentmain; their only remaining references were their own definitions and the two obsolete Session-export unit tests.Removed:
loaded_skills_from_export;assistant_from_export;test_failed_exported_skill_call_is_not_reported_as_loaded;test_session_export_preserves_tool_inputs_as_actions.Observable timing compatibility fields were left untouched because they are output data and were not proven dead.
Required-check recommendation
After this PR is merged, the repository ruleset should require exactly:
testruntime-integrationKeep strict/up-to-date required status checks enabled.
Publish imagesmust not be required.The ruleset is not changed in this PR: the available repository tools do not expose ruleset mutation, and enabling the new required check before the workflow lands on
maincould block other PRs that cannot yet produce it.Follow-up in GitHub UI after merge:
Settings → Rules → Rulesets → <active main ruleset> → Require status checks to passKeep
test, addruntime-integration, keep strict/up-to-date enabled, and do not addPublish images.Validation
Final head:
a5bb16e9bbe55efde1ab7a7f5eb9de8b07336495CI run #341 / 37593353163: PASS
test: PASSruntime-integration: PASSThe internal path decision excludes documentation-only changes such as
README.md/docs/**; for those PRs theruntime-integrationjob still starts and succeeds through its explicit not-applicable path, so a future required check will not hang.No
runtime_evidence/v1, trusted-checkout threat-model, orinvokesemantic changes were made.