Repository navigation
docs(actors): align createClient actors wording with the actors reference - #333
Open
abrahams-wix wants to merge 1 commit into
Open
abrahams-wix wants to merge 1 commit into
abrahams-wix wants to merge 1 commit into
Conversation
…ence Rewrite the onError JSDoc as a list of when the handler runs, say what error.status holds, and describe the actors field in the same terms as the actors reference (actor sessions, connections, messages). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.54-pr.333.b2eeefePrefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.54-pr.333.b2eeefe"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.54-pr.333.b2eeefe"
}
}
Preview published to npm registry — try new features instantly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onErrorJSDoc onCreateClientOptionsas a list of when the handler runs (a failed API request, or a client that can't connect to an actor).error.statusholds: the HTTP status code,undefinedfor network errors.actorsfield onBase44Clientin the actors reference's terms (actor sessions, connections, messages) and drop the Cloudflare Durable Object wording.JSDoc only. No runtime change. The generated
createClientandcreateClientFromRequestpages update from these comments.Notes
onErrorlines inclient.types.ts(em dash fix), so whichever merges second needs a small conflict fix.Test plan
tsc --noEmitpasses inpackages/sdk.npm run create-docs-localand confirmonErrorrenders as a list andactorsshows the new description on both pages.🤖 Generated with Claude Code