fix(annotate): add /api/save-notes POST endpoint to annotate server#884
Merged
backnotprop merged 6 commits intoJun 17, 2026
Merged
Conversation
Owner
|
thank you! |
backnotprop
force-pushed
the
fix/annotate-server-save-notes
branch
from
b52b6d5 to
2b29879
Compare
Copies the save-notes route from the plan review server into the annotate server (Bun source and Pi extension copy), enabling Save to Obsidian in annotation mode. Fixes backnotprop#844
Verifies saveToObsidian writes files correctly and handles missing vaults. HTTP endpoint tests cover success, empty integrations, and integration-level error (not 500). Imports consolidation from ./integrations into a single statement.
…lock bug Move the /api/save-notes logic into shared handler modules (shared-handlers.ts for Bun, handlers.ts for Pi) following the existing pattern for handleImage, handleUpload, handleDraftSave. Replaces four inline copies with two canonical implementations. Fixes: - Bun annotate catch block now correctly returns 500 (was logging only) - Misindented brace in Pi serverAnnotate.ts resolved by extraction - Revert unrelated port fallback change (keep server.port! for consistency) - Static imports in integrations.test.ts - Add /api/save-notes to CLAUDE.md Annotate Server API table
backnotprop
force-pushed
the
fix/annotate-server-save-notes
branch
from
2b29879 to
416719c
Compare
Owner
|
Thanks!! I cleaned up conflicts, extracted the save-notes handler into the shared handler modules, and fixed the catch-block bug. Ready for merge. |
backnotprop
force-pushed
the
fix/annotate-server-save-notes
branch
from
a7142bb to
447e322
Compare
…module
commands.test.ts mocked the annotate server with
`mock.module("@plannotator/server/annotate", ...)`. Bun module mocks are
process-global and cannot be unset (oven-sh/bun#7823, #12823), so the stub
leaked into every suite that runs after it — in particular any test that boots
the real annotate server received a stub with no `.url`.
Make `startAnnotateServer` injectable through the existing CommandDeps
(defaulting to the real import, so production is unchanged) and have the test
pass its stub that way. This keeps the fake local to the opencode suite and
unblocks real annotate-server integration tests.
backnotprop
force-pushed
the
fix/annotate-server-save-notes
branch
from
447e322 to
611809f
Compare
…ring - shared-handlers.test.ts: unit-test handleSaveNotes directly (Obsidian write, empty integrations, integration-error reported not thrown, 500 on bad body). - annotate.test.ts: boot the real annotate server and POST /api/save-notes, asserting it is served as JSON (not the SPA HTML catch-all) — the regression guard for backnotprop#844. Now possible because the opencode suite no longer installs a global annotate module mock.
backnotprop
force-pushed
the
fix/annotate-server-save-notes
branch
from
611809f to
c7ed99a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #844
Problem
Saving annotations to Obsidian (
Save to Obsidianbutton) fails silently in annotation mode. The button is visible and clickable but nothing happens because the annotate server lacks the/api/save-notesPOST route.The plan review server has this route and works correctly — only the annotate server was missing it.
Root Cause
packages/server/annotate.ts(Bun source) andapps/pi-extension/server/serverAnnotate.ts(Pi extension copy) did not implement the/api/save-noteshandler. When the frontend sends the save request in annotation mode, the server falls through to the HTML catch-all route, returning the SPA HTML instead of JSON.Changes
packages/server/annotate.ts— Added/api/save-notesPOST route handler with the same integration logic asserverPlan.ts: acceptsobsidian,bear, andoctarineconfigs, runs configured saves in parallel, returns{ ok: true, results }.apps/pi-extension/server/serverAnnotate.ts— Same route added to the Pi extension copy of the annotate server.packages/server/integrations.test.ts— AddedsaveToObsidianunit tests (success and missing vault cases). Consolidated duplicate imports from./integrationsinto a single statement.packages/server/annotate.test.ts— HTTP endpoint tests for the new route (success, empty integrations, integration-level error).Testing
All 205 server tests pass, 0 fail.