Skip to content

Fix pspm_convert_ppg2hb HeartPy handling and extend test coverage - #925

Open
4gwe wants to merge 8 commits into
developfrom
pspm_more_tests
Open

4gwe wants to merge 8 commits into
developfrom
pspm_more_tests

Conversation

@4gwe

@4gwe 4gwe commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes #597 and #652.

Changes proposed in this pull request:

  • Improved pspm_convert_hb2hp test coverage (Test function for convert_hb2hp #597).
  • Fixed HeartPy input handling in pspm_convert_ppg2hb.
  • Filtered out peaks rejected by HeartPy using binary_peaklist.
  • Improved HeartPy error handling.
  • Fixed LSM edge cases and option validation.
  • Added tests for HeartPy, rejected peaks, channel selection, invalid options, and LSM behavior.
  • Added HeartPy to the GitHub Actions dependencies.

@4gwe 4gwe changed the title Some test Some tests Sep 10, 2026
@4gwe 4gwe mentioned this pull request Sep 11, 2026
@4gwe 4gwe changed the title Some tests Fix pspm_convert_ppg2hb HeartPy handling and extend test coverage Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test function for convert_hb2hp

1 participant