Repository navigation
fix: handle SchemaRegistryURI that resolves to a string in MSK and SelfManagedKafka events - #4029
Merged
Merged
Conversation
…lfManagedKafka events
valerena
approved these changes
Nov 3, 2026
reedham-aws
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
When
SchemaRegistryConfig.SchemaRegistryURIis aRefto a template parameter that has a value(passed in or from
Default), the intrinsics resolver returns a plain string. The code inPullEventSource.get_schema_registry_permissionsthen called.get("Fn::Sub")on that string andthe transform failed with
AttributeError: 'str' object has no attribute 'get'.The resolved value is now handled as either a string or a dict:
Fn::Sub): same behavior as beforeApplies to both
MSKandSelfManagedKafkaevents.Description of how you validated changes
test_msk_event_source.pyandtest_self_managed_kafka_event_source.pyforSchemaRegistryURIasRefto a Glue ARN parameter,Refto a non-Glue URL parameter,Refto an unresolved parameter,Refto a resource,Fn::GetAttandFn::Sub.function_with_kafka_schema_registry_uri_ref_to_parameter(aws, aws-cn,aws-us-gov).
pull.pychange and pass with it.tests/model,tests/schemaandtests/translatorpass.Checklist
Examples?
N/A