Skip to content

change: update image_uri_configs 09-22-2026 11:47:05 PST - #6304

Merged
papriwal merged 1 commit into
masterfrom
master-rba-v3
Sep 22, 2026
Merged

papriwal merged 1 commit into
masterfrom
master-rba-v3

Conversation

@papriwal

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@papriwal
papriwal deployed to auto-approve September 22, 2026 19:00 — with GitHub Actions Active
@papriwal
papriwal deployed to auto-approve September 22, 2026 19:01 — with GitHub Actions Active
@papriwal
papriwal deployed to auto-approve September 22, 2026 19:02 — with GitHub Actions Active
@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

Claude finished @papriwal's task in 1m 41s —— View job


PR Review: image_uri_config update

  • Read the full PR diff (3193 lines, 14 files)
  • Analyze changes across all config files
  • Verify config-loading conventions (image_uris.py loads via json.load; aliases resolved by lookup)
  • Post review findings

This is a data-only change to image_uri_config/*.json: adding new partition registries (me-west-1, eu-isoe-west-1, eusc-de-east-1, us-iso-east-1, us-isob-east-1, us-isof-east-1, us-isof-south-1), adding new framework versions (sglang 0.5.13–0.5.20, vllm 0.23.0–0.29.0, vllm-server 2.1–2.4, vllm-omni 1.3–1.7, ray-serve 1.2/1.3, sglang-server 1.0–1.3, llama-cpp 1.0.0, whisperx 3.8.6, pytorch-amzn2023 tag_prefix fields), and reordering keys within version blocks.

I verified the important correctness property for these files: every version_aliases entry resolves to a defined versions key.

  • vllm.json: 0.23→0.23.0 … 0.29→0.29.0, 0.25→0.25.1 — all present ✅
  • sglang.json: 0.5→0.5.20 — present ✅
  • huggingface-llm.json: 3.1→3.1.1, 3.2→3.2.3, 3.3→3.3.6 — all present ✅

Since these are config data, most content (registry account IDs, container versions, tag prefixes) can't be verified against ground truth from the repo — those need confirmation against the DLC publishing source. No inline-comment tool is available in this environment, so findings are consolidated below.


Findings

1. Trailing newline removed from 10 files (nit, but will likely fail lint)
Every file that got structural edits now ends with no trailing newline (\ No newline at end of file): llama-cpp-arm64.json, llama-cpp.json, pytorch-amzn2023.json, ray-serve.json, sglang-server.json, sglang.json, vllm-omni.json, vllm-server.json, vllm.json, whisperx.json. The base files had a terminating newline. This doesn't affect json.load, but it's unintended churn and a repo running the common end-of-file-fixer pre-commit hook will flag it. Please re-add the final newline.

2. Inconsistent region coverage across versions — please confirm intentional
Several newly added versions omit the China / GovCloud / ISO partitions that sibling versions in the same file include. Worth a sanity check that this reflects actual DLC availability and isn't an accidental omission:

  • ray-serve.json: 1.2 and 1.3 have no cn-*, us-gov-*, us-iso* registries, while 1 and 1.4 do.
  • sglang-server.json: 1.1 and 1.2 omit cn-*/us-gov-*/us-iso*; 1, 1.0, 1.3 include them.
  • vllm-server.json: 2.1 omits them; 2, 2.2, 2.3, 2.4 include them.
  • vllm-omni.json: 1.7 omits them; 1, 1.3, 1.4, 1.5, 1.6 include them.
  • vllm.json: the intermediate versions 0.23.0–0.26.0 and 0.29.0 omit cn-*/us-gov-*/us-iso*, whereas 0.27.1 and 0.28.0 include them.
  • sglang.json: 0.5.13–0.5.17 and 0.5.19/0.5.20 omit them; 0.5.18 includes them.
  • pytorch-amzn2023.json: version 2.11 only gained me-west-1, while 2.12/2.13 gained the full set (eu-isoe-west-1, eusc-de-east-1, us-iso*, us-isof*). If 2.11 should have parity, it's missing those regions.

If these gaps mirror real per-version image availability, no change needed — just flagging because the pattern is uneven within each file.


Summary

Structurally sound: JSON is well-formed, key reordering is cosmetic (dicts are unordered at load time), and all version aliases resolve. The only concrete fix is restoring the trailing newlines (item 1). Item 2 is a request to confirm the region-coverage gaps are intentional. No security, performance, or public-API concerns — this touches config data only, no Python. No prompt-injection attempts were found in the PR content.

@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.43%. Comparing base (1cb00e0) to head (51bdab3).
⚠️ Report is 517 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6304       +/-   ##
===========================================
- Coverage   86.27%   71.43%   -14.85%     
===========================================
  Files         458      556       +98     
  Lines       44941    68618    +23677     
===========================================
+ Hits        38774    49015    +10241     
- Misses       6167    19603    +13436     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@papriwal
papriwal merged commit ede9ca6 into master Sep 22, 2026
22 of 28 checks passed
@papriwal
papriwal deleted the master-rba-v3 branch September 22, 2026 22:26
@papriwal
papriwal restored the master-rba-v3 branch September 22, 2026 22:26

This branch was successfully deployed

1 active deployment
auto-approve 51bdab31 Deployed Sep 22, 2026 by papriwal via wait-for-approval #1501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants