fix: handle unrecognized JumpStart container images in ModelBuilder#5818
Open
lhnealreilly wants to merge 1 commit intoaws:masterfrom
Open
fix: handle unrecognized JumpStart container images in ModelBuilder#5818lhnealreilly wants to merge 1 commit intoaws:masterfrom
lhnealreilly wants to merge 1 commit intoaws:masterfrom
Conversation
lhnealreilly
force-pushed
the
fix/jumpstart-default-model-server
branch
from
c4a18e7 to
7ee1044
Compare
lhnealreilly
force-pushed
the
fix/jumpstart-default-model-server
branch
from
7ee1044 to
471e1fb
Compare
Narrohag
approved these changes
May 1, 2026
varunmoris
approved these changes
May 1, 2026
Collapse endpoint mode routing into a single code path since all JumpStart builders (DJL, TGI, MMS) perform identical operations for endpoint deployment. Unknown container images (e.g. vLLM) now pass through instead of raising ValueError. For local container mode, unrecognized images raise ValueError with a message directing users to use SAGEMAKER_ENDPOINT mode.
lhnealreilly
force-pushed
the
fix/jumpstart-default-model-server
branch
from
471e1fb to
f48a573
Compare
varunmoris
approved these changes
May 1, 2026
Narrohag
approved these changes
May 1, 2026
aviruthen
approved these changes
May 1, 2026
Collaborator
aviruthen
left a comment
aviruthen
left a comment
There was a problem hiding this comment.
LGTM! Will investigate CI failures should confirm what they are before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse endpoint mode routing into a single code path since all JumpStart builders (DJL, TGI, MMS) perform identical operations for endpoint deployment. Unknown container images (e.g. vLLM) now pass through instead of raising ValueError.
For local container mode, unrecognized images raise ValueError with a message directing users to use SAGEMAKER_ENDPOINT mode.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.