Skip to content

Remove unused delay-shutdown REST endpoint#235

Merged
aakashmandavilli96 merged 1 commit intoaws:1.7from
azmkercso:remove-delay-shutdown-endpoint
Apr 20, 2026
Merged

Remove unused delay-shutdown REST endpoint#235
aakashmandavilli96 merged 1 commit intoaws:1.7from
azmkercso:remove-delay-shutdown-endpoint

Conversation

@azmkercso
Copy link
Copy Markdown
Collaborator

Issue #, if available:

  • P398067552

Description of changes:

  • Remove the /delay-shutdown HTTP endpoint and its backing _delayShutdown() method from remoteExtensionHostAgentServer.ts
  • This feature is not used by the service — the shutdown lifecycle is fully managed by extension host connection events (_onDidCloseExtHostConnection)
  • The endpoint was positioned before the connection token validation, meaning it required no authentication
  • After this change, GET /delay-shutdown returns 403 (without token) or 404 (with token) instead of 200

Testing:

  • Verified all existing patches apply cleanly with the new patch appended (quilt push -a succeeds)
  • Confirmed no references to delay-shutdown or _delayShutdown remain in the patched source
  • Confirmed _cancelShutdown() and _waitThenShutdown() are preserved (still used by _onDidCloseExtHostConnection)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Remove the /delay-shutdown HTTP endpoint and its _delayShutdown() method
from remoteExtensionHostAgentServer. This feature is not used by the
service and the shutdown lifecycle is fully managed by the extension host
connection events.
@aakashmandavilli96 aakashmandavilli96 merged commit 337a96d into aws:1.7 Apr 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants