Repository navigation
Conversation
sbiscigl
marked this pull request as ready for review
October 29, 2026 20:02
sbaluja
approved these changes
Oct 30, 2026
sbiscigl
force-pushed
the
crt-tls-failure
branch
from
October 30, 2026 18:23
ff0ff0f to
1a3c3b3
Compare
DmitriyMusatkin
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
When
CRTHttpClientfailed to set up TLS (for example an unreadablecaFile,caPathorproxyCaFile), it marked itself bad but nothing checked that flag. It now refuses every request with a non-retryableINVALID_PARAMETER_COMBINATIONerror when it's bad, sets the flag on proxy TLS failures too, andCreateHttpClientnow actually checks the client'soperator boolinstead of just checking for a null pointer. This is a behavior change for misconfigured clients only: a CRT client with an unreadable CA file now fails all requests.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.