refactor(durable): Remove time scale configuration from emulator container - #9169
Draft
ayushiahjolia wants to merge 1 commit into
Draft
refactor(durable): Remove time scale configuration from emulator container#9169ayushiahjolia wants to merge 1 commit into
ayushiahjolia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Related to aws/aws-durable-execution-sdk-python#523
Why is this change necessary?
The time scale feature has been removed from the durable execution emulator (see linked SDK PR). The
DURABLE_EXECUTIONS_TIME_SCALEenvironment variable and theDURABLE_EXECUTION_TIME_SCALEcontainer environment variable are no longer recognized by the emulator, so SAM CLI should stop setting them.How does it address the issue?
ENV_TIME_SCALEclass variable and its docstring_get_emulator_time_scale()method_get_emulator_environment()to return an empty dictcustom_time_scaletest caseWhat side effects does this change have?
Users who previously set
DURABLE_EXECUTIONS_TIME_SCALEwill no longer see it forwarded to the emulator container. Since the emulator itself no longer supports this variable, there is no functional impact.Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.