feat(events): add MultiValueHeaders to LambdaFunctionURLResponse#628
Open
feat(events): add MultiValueHeaders to LambdaFunctionURLResponse#628
Conversation
AWS Lambda Function URLs can return multiple values for the same header key (e.g. multiple Set-Cookie headers). Without MultiValueHeaders, callers had to work around the single-value Headers map and could not set more than one cookie in a single response. Adds MultiValueHeaders map[string][]string with omitempty, matching the shape already present on APIGatewayProxyResponse and APIGatewayV2HTTPResponse, and adds a round-trip marshaling test with a multi-cookie fixture. Fixes aws#556
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 75.12% 75.12%
=======================================
Files 36 36
Lines 1419 1419
=======================================
Hits 1066 1066
Misses 274 274
Partials 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LambdaFunctionURLResponseonly has a single-valueHeaders map[string]string, which makes it impossible to set more than one value for the same header key — the most common case being multipleSet-Cookieheaders.The equivalent response types (
APIGatewayProxyResponse,APIGatewayV2HTTPResponse) already haveMultiValueHeaders map[string][]stringfor this exact reason.Closes #556
Changes
MultiValueHeaders map[string][]string \json:"multiValueHeaders,omitempty"`toLambdaFunctionURLResponse`, matching the shape of the existing gateway response types.TestLambdaFunctionURLResponseMultiValueHeadersMarshaling) with a fixture containing a multi-cookieSet-Cookieheader.Testing
All existing tests continue to pass. New test exercises the multi-value path.