Repository navigation
fix(otel): restore case 11 replay coverage - #864
Merged
Merged
Conversation
Contributor
Codex AI reviewOne rule 6 approach finding at Reviewed commit |
3 tasks done
hln33
approved these changes
Oct 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Extracted from #796 for independent early merge. Main's failing run: https://github.com/aws/aws-durable-execution-sdk-python/actions/runs/40554880874.
Description of changes
Case 11 returns immediately after its child completes, but the shared conformance requirement expects a callback barrier followed by another caller replay. Main reports
ContextStarted/CallbackStartedmissing and ends the execution before the required history events exist.Add the existing
wait_for_callbackoperation after the invoke, then return the saved child result. The regression test exercises both telemetry views through the real local runner: exactly one child execution, three caller invocations, one callback submitter execution, and the original nested payload returned after resume.Main also reports seven uncovered requirements per view, and its workflow fails on
failed+uncovered. Declare the absent coverage explicitly with the runner's existingNotImplementedmetadata: cases 21–24 and 27 are pending in #796; cases 25–26 link to their runtime/testing follow-ups. All 20 existing cases remain active. The newer handlers and workflow changes stay in #796.Design
wait_for_callbackwith the exact scenario name.Assumptions
otel-invoke-replay-barrier, supplies its success payload, and delays completion until the caller invocation has ended.Decisions not covered by the issue or the design note
Validation
NotImplementedis absent.hatch run test:all packages/aws-durable-execution-sdk-python-conformance-tests-otel/tests -q --tb=short— 55 passed on Python 3.13.17.hatch fmt --checkandhatch build— passed.git diff --check— passed.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.