fix: avoid vendoring adot layer dependencies - #628
Merged
Conversation
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 20:55 — with
GitHub Actions
Inactive
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 20:55 — with
GitHub Actions
Inactive
Contributor
Codex AI reviewNo actionable findings. Residual risk: no committed cloud integration test exercises the universal layer with ADOT across all advertised runtimes and architectures. Reviewed commit |
This comment has been minimized.
This comment has been minimized.
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 21:04 — with
GitHub Actions
Inactive
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 21:04 — with
GitHub Actions
Inactive
ayushiahjolia
approved these changes
Aug 11, 2026
Contributor
Claude AI reviewNo blocking findings. The change is coherent and the tests directly cover the fix. What the PR does
Residual risks (not defects in the diff; flagged for awareness)
Reviewed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The layer builder resolved the plugin dependencies into
/opt/python, overriding OpenTelemetry packages supplied by ADOT. The mixed versions prevented ADOT initialization and X-Ray trace export.Testing
hatch run test:all .github/scripts/tests/test_build_lambda_layer.py .github/scripts/tests/test_parse_sdk_branch.py .github/scripts/tests/test_resolve_layer_sdk_version.pyhatch fmt --check .github/scripts/build_lambda_layer.py .github/scripts/tests/test_build_lambda_layer.py