feat(plugin): stabilize plugin interface and otel package - #625
Merged
Conversation
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 04:43 — with
GitHub Actions
Inactive
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 04:43 — with
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 04:48 — with
GitHub Actions
Inactive
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
August 11, 2026 04:48 — with
GitHub Actions
Inactive
Contributor
Codex AI reviewNo actionable findings. Residual risk is limited to tests not being executed under the review constraints. Reviewed commit |
Contributor
Claude AI reviewNo actionable findings. This is a clean, well-scoped stabilization PR:
The attribute docstrings are no-op statements and are not flagged by the configured Ruff rule set ( Residual test risk (not a finding):
Reviewed commit |
wangyb-A
approved these changes
Aug 11, 2026
wangyb-A
pushed a commit
that referenced
this pull request
Aug 11, 2026
Mark execution_input and execution_result with
metadata={"experimental": True} and a leading EXPERIMENTAL docstring,
matching the pattern #625 established for OperationInfo.result /
OperationInfo.error / InvocationEndInfo.error.
Unlike a docstring alone the metadata is introspectable at runtime, so
the generic test #625 added -- which requires the marker on every
plugin info field named for input, output, result or error -- now
covers these two fields. That test fails on this branch without them.
This matters more since #625 removed the plugins= FutureWarning: the
per-field markers are now the only stability signal on these surfaces.
Refs #616
wangyb-A
pushed a commit
that referenced
this pull request
Aug 11, 2026
Mark execution_input and execution_result with
metadata={"experimental": True} and a leading EXPERIMENTAL docstring,
matching the pattern #625 established for OperationInfo.result /
OperationInfo.error / InvocationEndInfo.error.
Unlike a docstring alone the metadata is introspectable at runtime, so
the generic test #625 added -- which requires the marker on every
plugin info field named for input, output, result or error -- now
covers these two fields. That test fails on this branch without them.
This matters more since #625 removed the plugins= FutureWarning: the
per-field markers are now the only stability signal on these surfaces.
Refs #616
wangyb-A
pushed a commit
that referenced
this pull request
Aug 11, 2026
Addresses the medium-severity Codex review comment on #616. The payload fields joined the generated __eq__ and __hash__, so the widening was not additive. execution_input holds arbitrary deserialized JSON, and a dict or list value made a previously hashable InvocationStartInfo raise TypeError on hash(); both fields also made infos built from the earlier field set compare unequal to infos carrying a payload. Both effects were reproduced first. Set compare=False, hash=False on execution_input and execution_result. Identity fields still drive equality, so payload-only differences now compare equal -- payloads are incidental data on what is otherwise an event record. Adds tests for hashability across dict, list, nested and scalar payloads, for equality against the prior field set, and for the field declarations themselves. Note OperationInfo.result / OperationInfo.error from #625 remain in compare. They are hashable types so they do not break hash(), but the equality asymmetry with these fields is worth a maintainer decision. Refs #616
wangyb-A
pushed a commit
that referenced
this pull request
Aug 11, 2026
Addresses the medium-severity Codex review comment on #616. The payload fields joined the generated __eq__ and __hash__, so the widening was not additive. execution_input holds arbitrary deserialized JSON, and a dict or list value made a previously hashable InvocationStartInfo raise TypeError on hash(); both fields also made infos built from the earlier field set compare unequal to infos carrying a payload. Both effects were reproduced first. Set compare=False, hash=False on execution_input and execution_result. Identity fields still drive equality, so payload-only differences now compare equal -- payloads are incidental data on what is otherwise an event record. Adds tests for hashability across dict, list, nested and scalar payloads, for equality against the prior field set, and for the field declarations themselves. Note OperationInfo.result / OperationInfo.error from #625 remain in compare. They are hashable types so they do not break hash(), but the equality asymmetry with these fields is worth a maintainer decision. Refs #616
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FutureWarningfrom thepluginshandler parameterinput,output,result, orerrorto carry the experimental markerTesting
git diff --checkpassedThe local shell only provides Python 3.10, while the SDK requires Python 3.11+, so the focused test used compatibility shims for
typing.Self,datetime.UTC, andenum.StrEnum. CI will run the full suite with the supported toolchain.