Repository navigation
ci: run telemetry conformance via shared workflow - #825
ParidelPooya merged 1 commit into
Conversation
The workflow calls the shared telemetry suite in the conformance repository at a pinned SHA. It runs on pull requests and pushes to main that touch the SDK, the exporter, or the handler module. It also runs on manual dispatch. The prepare step installs the sdk and telemetry-exporter modules into the local Maven repository. The handler pom depends on both at the durable.sdk.version property. So the step must install them before it compiles the handlers. The handler pom reads that property from the JAVA_SDK_VERSION environment variable. The runner's sam build runs in a later step. Only GITHUB_ENV carries values to later steps. So the prepare step writes JAVA_SDK_VERSION to GITHUB_ENV.
0feb243 to
a7f0dde
Compare
Codex AI reviewNo actionable findings in the PR changes. Residual test risk: CI/cloud tests were not run, and the pinned external reusable workflow was unavailable for local inspection. Reviewed commit |
|
The red The suite fails the record because the keys of aws/aws-durable-execution-conformance-tests#166 removes the key-order assertion. The check still requires exactly the expected keys and compares every value, and it still compares list items in order. After #166 merges, this job should pass with no Java change. The pin Two other notes on the workflow:
|
Stack
Stacked on #822. Base branch:
feat/conformance-tests-telemetry. Retarget tomainand drop the branch filter after the parent merges.Changes
.github/workflows/telemetry-conformance-tests.yml. It calls the shared telemetry suite from the conformance repository.mainthat touchsdk/**,telemetry-exporter/**,conformance-tests-telemetry/**,pom.xml, or the workflow file. It also supports manual dispatch.prepare_commandinstalls thesdkandtelemetry-exportermodules, then compiles the handlers as a check before deployment.prepare_commandwritesJAVA_SDK_VERSIONtoGITHUB_ENV. The handler pom reads it, and the runner'ssam buildruns in a later step.setup_commandis copied fromotel-conformance-tests.yml. It selects Java 21.conformance-tests-telemetry/README.mdwith a## CIsection.Shared workflow pin
3e4fdaf0, the head of aws/aws-durable-execution-conformance-tests#150. It includes the exact-record golden check from #160. Re-pin to the merge commit after #150 lands.Verification
setup_commandandprepare_commandpassbash -n.shellcheckreports one SC2155 warning in thesetup_commandblock copied unchanged fromotel-conformance-tests.yml.mvn help:evaluate -Dexpression=project.versionreturns3.0.0.0feb2439): every workflow step through deploy and invocation passed.Prepare SDK handlersselected Java 21, installedsdkandtelemetry-exporter, and compiled the handler module.sam buildandDeploy succeeded. The runner invokedTelemetry1Success, saved the execution history, and fetched the telemetry record. So the CI wiring works end to end.telemetry-1record-shape assertions. These are exporter deviations from the JS reference format, out of scope for this PR:operationsByName.incrementkey order differs. The exporter fix is a separate change; this job turns green once it lands.