ci: publish Java OTel Lambda layer - #621
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| (.Principal | type) == "object" | ||
| and .Principal.AWS == "*" | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Codex AI review
[P2] Reject conditioned policies as non-public. An organization-scoped layer permission also has Principal: "*", but adds a restrictive Condition. After a statement-ID conflict, this check would accept that policy and report the layer as publicly available even though external accounts cannot use it. Require the matching statement to have no condition, and fail or replace restricted statements.
| ) | |
| ) | |
| and (.Condition == null) |
Codex AI reviewFound one permission-validation issue. Static review only; this release/manual workflow has no PR-time execution coverage. Reviewed commit |
Claude AI reviewThis PR adds a single CI workflow ( I verified the workflow against the repository facts it depends on and found them consistent:
No actionable, confirmed findings. Residual (non-blocking) risks worth noting, not raised as findings because each is a defensible design choice rather than a defect:
Reviewed commit |
Summary
java/libRuntime contract
GLOBALprovider path uses the OTel API/SDK extension surface supplied by the ADOT or OpenTelemetry Java agent layerOTEL_JAVAAGENT_EXTENSIONSand select it throughDURABLE_EXECUTION_PLUGINSAUTO_OTLPand custom tracer-provider paths still require the function to supply their OTel SDK/exporter dependenciesConfiguration
lambda-layer-publishenvironment withLAYER_PUBLISH_ROLE_ARNLAYER_PUBLISH_REGIONS; otherwise the commercial Region defaults are usedv*.*.*and themainbranch for manual runsValidation
git diff --check